Skip to content

Add skip_names and LoRALinear guard to replace_linear_with_split_linear#18346

Open
lucylq wants to merge 6 commits intogh/lucylq/144/headfrom
gh/lucylq/145/head
Open

Add skip_names and LoRALinear guard to replace_linear_with_split_linear#18346
lucylq wants to merge 6 commits intogh/lucylq/144/headfrom
gh/lucylq/145/head

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Mar 19, 2026

Skip LoRALinear modules to prevent splitting lora_a/lora_b sub-layers.
Add skip_names parameter so callers can prevent splitting specific
named children (needed for POSITIONAL weight sharing with CoreML).

Authored with Claude.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 19, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18346

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Pending, 2 Unrelated Failures

As of commit d58628d with merge base dd7464a (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2026
lucylq added 3 commits March 19, 2026 14:50
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
from executorch.examples.models.llama.lora import LoRALinear

for name, module in model.named_children():
if skip_names and name in skip_names:
Copy link
Contributor Author

@lucylq lucylq Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the next PR, this ends up being 'wqs', 'wks', 'wvs', 'wos'. Regular linear and LoraLinear both have to be skipped.

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant