Add skip_names and LoRALinear guard to replace_linear_with_split_linear#18346
Open
lucylq wants to merge 6 commits intogh/lucylq/144/headfrom
Open
Add skip_names and LoRALinear guard to replace_linear_with_split_linear#18346lucylq wants to merge 6 commits intogh/lucylq/144/headfrom
lucylq wants to merge 6 commits intogh/lucylq/144/headfrom
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18346
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Pending, 2 Unrelated FailuresAs of commit d58628d with merge base dd7464a ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 19, 2026
Merged
lucylq
commented
Mar 20, 2026
| from executorch.examples.models.llama.lora import LoRALinear | ||
|
|
||
| for name, module in model.named_children(): | ||
| if skip_names and name in skip_names: |
Contributor
Author
There was a problem hiding this comment.
in the next PR, this ends up being 'wqs', 'wks', 'wvs', 'wos'. Regular linear and LoraLinear both have to be skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip LoRALinear modules to prevent splitting lora_a/lora_b sub-layers.
Add skip_names parameter so callers can prevent splitting specific
named children (needed for POSITIONAL weight sharing with CoreML).
Authored with Claude.