Fix missing override on XnnpackBackend destructor#18389
Fix missing override on XnnpackBackend destructor#18389amov-meta wants to merge 1 commit intopytorch:mainfrom
override on XnnpackBackend destructor#18389Conversation
Summary: Add missing `override` keyword to `XnnpackBackend::~XnnpackBackend()`. The destructor overrides a virtual base class destructor from `BackendInterface` but was not marked `override`, which triggers `-Werror,-Winconsistent-missing-destructor-override` on strict toolchains (e.g. the ARVR toolchain on macOS). Differential Revision: D97373597
2fe12ca to
7151599
Compare
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18389
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 7151599 with merge base 81dea65 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@amov-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97373597. |
This PR needs a
|
Summary:
Add missing
overridekeyword toXnnpackBackend::~XnnpackBackend().The destructor overrides a virtual base class destructor from
BackendInterfacebut was not markedoverride, which triggers-Werror,-Winconsistent-missing-destructor-overrideon stricttoolchains (e.g. the ARVR toolchain on macOS).
Differential Revision: D97373597