Skip to content

Add optional offset arg to quantized_conv1d_nlc and precompute it AOT (#19344)#19344

Open
khazaei wants to merge 1 commit intopytorch:mainfrom
khazaei:export-D103893688
Open

Add optional offset arg to quantized_conv1d_nlc and precompute it AOT (#19344)#19344
khazaei wants to merge 1 commit intopytorch:mainfrom
khazaei:export-D103893688

Conversation

@khazaei
Copy link
Copy Markdown
Contributor

@khazaei khazaei commented May 6, 2026

Summary:

Extends cadence::quantized_conv1d_nlc (per_tensor / per_tensor_out) with
an optional offset tensor that carries the precomputed zero-point
correction term -(sum(W) * X_z) per output channel.

  • Updates the op schema in functions.yaml / functions_hifi.yaml /
    ops_registrations.py to add Tensor? offset=None.
  • Threads the new offset argument through the generic and HiFi conv1d_nlc
    kernels (currently unused by these kernels).
  • Updates the depthwise conv1d_nlc callers to pass an empty optional.
  • Extends PrecomputeForQuantizedConvPass to also precompute the offset
    for quantized_conv1d_nlc.per_tensor (sum over weight dims [1, 2]) and
    adds a unit test for the new path.

Reviewed By: abeakkas

Differential Revision: D103893688

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 6, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19344

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 18 Unrelated Failures

As of commit 8c1a576 with merge base af90130 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 6, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 6, 2026

@khazaei has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103893688.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync Bot changed the title Add optional offset arg to quantized_conv1d_nlc and precompute it AOT Add optional offset arg to quantized_conv1d_nlc and precompute it AOT (#19344) May 6, 2026
khazaei pushed a commit to khazaei/executorch that referenced this pull request May 6, 2026
…pytorch#19344)

Summary:

Extends `cadence::quantized_conv1d_nlc` (per_tensor / per_tensor_out) with
an optional `offset` tensor that carries the precomputed zero-point
correction term `-(sum(W) * X_z)` per output channel.

- Updates the op schema in functions.yaml / functions_hifi.yaml /
  ops_registrations.py to add `Tensor? offset=None`.
- Threads the new `offset` argument through the generic and HiFi conv1d_nlc
  kernels (currently unused by these kernels).
- Updates the depthwise conv1d_nlc callers to pass an empty optional.
- Extends `PrecomputeForQuantizedConvPass` to also precompute the offset
  for `quantized_conv1d_nlc.per_tensor` (sum over weight dims [1, 2]) and
  adds a unit test for the new path.

Reviewed By: abeakkas

Differential Revision: D103893688
@khazaei khazaei force-pushed the export-D103893688 branch from 959c7d7 to 1538a0e Compare May 6, 2026 21:54
khazaei pushed a commit to khazaei/executorch that referenced this pull request May 6, 2026
…pytorch#19344)

Summary:

Extends `cadence::quantized_conv1d_nlc` (per_tensor / per_tensor_out) with
an optional `offset` tensor that carries the precomputed zero-point
correction term `-(sum(W) * X_z)` per output channel.

- Updates the op schema in functions.yaml / functions_hifi.yaml /
  ops_registrations.py to add `Tensor? offset=None`.
- Threads the new `offset` argument through the generic and HiFi conv1d_nlc
  kernels (currently unused by these kernels).
- Updates the depthwise conv1d_nlc callers to pass an empty optional.
- Extends `PrecomputeForQuantizedConvPass` to also precompute the offset
  for `quantized_conv1d_nlc.per_tensor` (sum over weight dims [1, 2]) and
  adds a unit test for the new path.

Reviewed By: abeakkas

Differential Revision: D103893688
@khazaei khazaei force-pushed the export-D103893688 branch from 1538a0e to 64c00b7 Compare May 6, 2026 23:19
…pytorch#19344)

Summary:

Extends `cadence::quantized_conv1d_nlc` (per_tensor / per_tensor_out) with
an optional `offset` tensor that carries the precomputed zero-point
correction term `-(sum(W) * X_z)` per output channel.

- Updates the op schema in functions.yaml / functions_hifi.yaml /
  ops_registrations.py to add `Tensor? offset=None`.
- Threads the new `offset` argument through the generic and HiFi conv1d_nlc
  kernels (currently unused by these kernels).
- Updates the depthwise conv1d_nlc callers to pass an empty optional.
- Extends `PrecomputeForQuantizedConvPass` to also precompute the offset
  for `quantized_conv1d_nlc.per_tensor` (sum over weight dims [1, 2]) and
  adds a unit test for the new path.

Reviewed By: abeakkas

Differential Revision: D103893688
@khazaei khazaei force-pushed the export-D103893688 branch from 64c00b7 to 8c1a576 Compare May 7, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants