Use HAS_CUPTI_RANGE_PROFILER to avoid range profiler init#1298
Closed
Use HAS_CUPTI_RANGE_PROFILER to avoid range profiler init#1298
Conversation
Summary: Range profiler initialization (CuptiRangeProfilerInit) was running whenever HAS_CUPTI was defined, even when HAS_CUPTI_RANGE_PROFILER was not defined (i.e., range profiler is not actually supported). That is bad because 1. This would be causing unnecessary memory allocation for unique_ptr rangeProfilerInit. 2. It leads to registration of CuptiRangeProfilerConfig factory Reviewed By: aaronenyeshi, scotts Differential Revision: D94610428
|
@divyanshk has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94610428. |
aaronenyeshi
approved these changes
Mar 11, 2026
Member
aaronenyeshi
left a comment
aaronenyeshi
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This pull request has been merged in 1f9ceb1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Range profiler initialization (CuptiRangeProfilerInit) was running whenever HAS_CUPTI was defined, even when HAS_CUPTI_RANGE_PROFILER was not defined (i.e., range profiler is not actually supported).
That is bad because
Reviewed By: aaronenyeshi, scotts
Differential Revision: D94610428