fix: replace torch.functional import with preferred torch.nn.functional#3756
fix: replace torch.functional import with preferred torch.nn.functional#3756svekars merged 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3756
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ded702b with merge base f3d9750 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @vinayaksodar! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@svekars is there CI on this? I would have expected that we caught this before. If the answer is that there is no CI on this, then I would check this out locally and see if it actually runs. NB: I'm going to be sporadic for a couple of days |
zou3519
left a comment
There was a problem hiding this comment.
if it works both ways then nn.functional as F is preferred
Fixes #3755
Description
replace invalid torch.functional import with torch.nn.functionalv
Checklist
cc @zou3519 @albanD @jbschlosser