Skip to content

Restructure error handling for semantics#160

Closed
TheGupta2012 wants to merge 1 commit intomainfrom
restructure-errors
Closed

Restructure error handling for semantics#160
TheGupta2012 wants to merge 1 commit intomainfrom
restructure-errors

Conversation

@TheGupta2012
Copy link
Copy Markdown
Member

Summary of changes

Fixes #149

  • We want to have a better way to emit errors to the user when doing semantic analysis. Currently we stop processing after an error is encountered, which may not be the best strategy for error discovery
  • Tasks -
    • Define warning and fatal errors
    • Strategy for warnings
    • Strategy for fatal errors
    • Error threshold
    • Tests

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 24, 2024

Codecov Report

❌ Patch coverage is 92.42424% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
qbraid_qir/qasm3/visitor.py 91.11% 4 Missing ⚠️
qbraid_qir/qasm3/exceptions.py 92.85% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ryanhill1
Copy link
Copy Markdown
Member

@TheGupta2012 can we close? Or turn it into an open issue?

@TheGupta2012
Copy link
Copy Markdown
Member Author

I think this is pretty stale, we've developed Pyqasm quite a bit since then - can close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error reporting for openqasm semantics

2 participants