Address race condition during synchronization of datasets between Qbis and DM#1385
Merged
Address race condition during synchronization of datasets between Qbis and DM#1385
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Currently the raw dataset information is synchronised between openbis and the data manger via a dedicated synchronization service which sets and retrieves watermarks to get the current progress of synchronization.
However if datasets are registered within the synchronization (As can happen if bigger datasets are registered in openbis) then the watermark setting does not work correctly since it sets the update interval to instance.now() after pagination instead of the timepoint of the last successful synchronization.
Note
1.) This is just a hotfix, this does NOT fix missing datasets which already were not synchronized.
2.) The current implementation does not account for update or deletion of datasets in openbis, since it solely relies on time points which is less than ideal. The current state of datasets should be synchronized dependent on the entities not on some watermark based timepoint.