Update base_sha and head_sha for kernel checkers#65
Open
hasiburr-qti wants to merge 1 commit intoqualcomm-linux:mainfrom
Open
Update base_sha and head_sha for kernel checkers#65hasiburr-qti wants to merge 1 commit intoqualcomm-linux:mainfrom
hasiburr-qti wants to merge 1 commit intoqualcomm-linux:mainfrom
Conversation
This commit ensures that the `head_sha` and the `base_sha` are not passed as input to the checker action, instead the head and base shas' are determined after the workspace is ready, which ensures that proper changes history is passed to the checker script for analysis. This commit removes the `prepare` job from the workflow it isnn't not required now. The similar commit to `kernel-checkers` repo is also made to accommodate changes done in using the checker workflow. Signed-off-by: Hasibur Rahman Mohammed <hasiburr@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the
head_shaand thebase_shaare not passed as input to the checker action, instead the head and base shas' are determined after the workspace is ready, which ensures that proper changes history is passed to the checker script for analysis.This PR removes the
preparejob from the workflow it isnn't not required now. The similar commit tokernel-checkersrepo is also made to accommodate changes done in using the checker workflow.This PR is dependent on: qualcomm-linux/kernel-checkers#20