FROMLIST: driver: bluetooth: hci_qca: Cleanup on all setup failures#652
Open
jinwli-qc wants to merge 1 commit intoqualcomm-linux:tech/net/bluetoothfrom
Open
FROMLIST: driver: bluetooth: hci_qca: Cleanup on all setup failures#652jinwli-qc wants to merge 1 commit intoqualcomm-linux:tech/net/bluetoothfrom
jinwli-qc wants to merge 1 commit intoqualcomm-linux:tech/net/bluetoothfrom
Conversation
The setup process previously combined error handling and retry gating under one condition. As a result, the final failed attempt exited without performing cleanup. Update the failure path to always perform power and port cleanup on setup failure, and reopen the port only when retrying. Fixes: 9e80587 ("Bluetooth: hci_qca: Enhance retry logic in qca_setup") Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> Link: https://lore.kernel.org/all/20260205062600.590342-1-jinwang.li@oss.qualcomm.com/ CRs-Fixed: 4378012
shashim-quic
requested changes
Feb 13, 2026
Collaborator
shashim-quic
left a comment
shashim-quic
left a comment
There was a problem hiding this comment.
CRs-Fixed: 4378012
remove CRs-Fixed from commit log. Only adding to PR description is sufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setup process previously combined error handling and retry gating under one condition. As a result, the final failed attempt exited without performing cleanup.
Update the failure path to always perform power and port cleanup on setup failure, and reopen the port only when retrying.
Fixes: 9e80587 ("Bluetooth: hci_qca: Enhance retry logic in qca_setup")
Signed-off-by: Jinwang Li jinwang.li@oss.qualcomm.com
Reviewed-by: Bartosz Golaszewski bartosz.golaszewski@oss.qualcomm.com
Link: https://lore.kernel.org/all/20260205062600.590342-1-jinwang.li@oss.qualcomm.com/
CRs-Fixed: 4378012