WORKAROUND: Enable ethernet on Talos Ride SX#678
Open
ayaan-anwar wants to merge 4 commits intoqualcomm-linux:tech/all/workaroundfrom
Open
WORKAROUND: Enable ethernet on Talos Ride SX#678ayaan-anwar wants to merge 4 commits intoqualcomm-linux:tech/all/workaroundfrom
ayaan-anwar wants to merge 4 commits intoqualcomm-linux:tech/all/workaroundfrom
Conversation
In the initial device tree submission, the definitions of rgmii and rgmii-id in the phy-mode property were inverted compared to the conventions used by the upstream Linux kernel community. Only QCS-EVB-400 and SA8155-ADP platforms are affected due to the incorrect PHY mode configuration: 'rgmii' was used instead of the correct 'rgmii-id'. This change results in an ABI compatibility break, but it is acceptable as these platforms are not actively used by any customers, based on current observations. Qualcomm expects the MAC, not the PHY, to introduce the timing delay, and the driver is designed accordingly. This is due to specific SoC hardware that handles delay and sampling internally. Link: https://lore.kernel.org/netdev/20250819-qcs615_eth-v4-2-5050ed3402cb@oss.qualcomm.com/ Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com> Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
|
Change looks fine. |
Add an ethernet controller node for QCS615 SoC to enable ethernet functionality. Link: https://lore.kernel.org/netdev/20250819-qcs615_eth-v4-3-5050ed3402cb@oss.qualcomm.com/ Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Enable the ethernet node, add the phy node and pinctrl for ethernet. Link: https://lore.kernel.org/netdev/20250819-qcs615_eth-v4-4-5050ed3402cb@oss.qualcomm.com/ Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
…gets RX_PROG_SWAP is a tuning parameters without which 100M/10M speeds are non-functional in RGMII mode in the qcom-ethqos EMAC core. Enable it. Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
ayaan-anwar
force-pushed
the
tech/all/workaround
branch
from
d231c26 to
12f939a
Compare
Author
|
Should this be split into 2 PRs? One with 3 FROMLIST patches destined for tech/all/dt/qcs615 and the last commit in tech/all/workaround? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to issues with how the Talos EMAC handles RGMII delays, Ethernet functionality has not been approved in upstream. We are working with the HW team to come up with a solution that is aligned to upstream expectations. Until then, this PR adds the necessary changes to enable ethernet on the Talos Ride SX board. The QLIJIRA, approved for this temporary exception, is linked below.
All the changes are marked with a "WORKAROUND:" tag as 3/4 commits are aged-out patches and the last commit is required to ensure that 100M link speed is functional. All 4 commits are temporary until we figure out the correct HW programming to align with upstream preferred behavior.
QLIJIRA: QLIJIRA-101
CRs-Fixed: 4436907
Signed-off-by: Mohd Ayaan Anwar mohd.anwar@oss.qualcomm.com