arm64: dts: qcom: shikra: Add PMIC thermal and ADC support#888
arm64: dts: qcom: shikra: Add PMIC thermal and ADC support#888kotarake wants to merge 1 commit intoqualcomm-linux:early/hwe/shikra/dtfrom
Conversation
Komal-Bajaj
force-pushed
the
early/hwe/shikra/dt
branch
from
74255bb to
16980ad
Compare
kotarake
force-pushed
the
shikra-dt
branch
3 times, most recently
from
bcde924 to
a057960
Compare
arch/arm64/boot/dts/qcom/pm4125.dtsi
Outdated
| }; | ||
|
|
||
| channel@2a { | ||
| reg = <ADC5_BAT_THERM_30K_PU>; |
There was a problem hiding this comment.
You can remove the channels with these channel numbers:
ADC5_BAT_THERM_30K_PU
ADC5_BAT_THERM_100K_PU
ADC5_BAT_THERM_400K_PU
ADC5_PARALLEL_ISENSE
Because these are not present in the mapping table in the ADC driver I see upstream, so their scaling functions will not be supported right now.
arch/arm64/boot/dts/qcom/pm8005.dtsi
Outdated
| pm8005_tz: temp-alarm@2400 { | ||
| compatible = "qcom,spmi-temp-alarm"; | ||
| reg = <0x2400>; | ||
| interrupts = <0x0 0x24 0x0 IRQ_TYPE_EDGE_BOTH>; |
There was a problem hiding this comment.
update in next patch
| }; | ||
|
|
||
| &pm4125_resin { | ||
| linux,code = <KEY_VOLUMEUP>; |
There was a problem hiding this comment.
update in next patch-set
| gpios = <&pm4125_gpios 9 GPIO_ACTIVE_LOW>; | ||
| linux,input-type = <1>; | ||
| linux,code = <KEY_VOLUMEUP>; | ||
| gpio-key,wakeup; |
There was a problem hiding this comment.
I think "gpio-key,wakeup" does not exist.....should this be wakeup-source ?
There was a problem hiding this comment.
update in next patch-set
| pinctrl-names = "default"; | ||
|
|
||
| channel@56 { | ||
| reg = <ADC5_GPIO5_100K_PU>; |
There was a problem hiding this comment.
GPIOs 5 and 6 of Cocos have channel numbers 0x54 and 0x55, which are ADC5_GPIO3_100K_PU and ADC5_GPIO4_100K_PU
There was a problem hiding this comment.
update in next patch-set
| }; | ||
|
|
||
| &pm8150_adc_tm { | ||
| status = "okay"; |
There was a problem hiding this comment.
Check the indentation for this line
| sys-therm-3 { | ||
| polling-delay-passive = <2000>; | ||
| polling-delay = <0>; | ||
| thermal-sensors = <&pm8150_adc_tm 3>; |
There was a problem hiding this comment.
Should this be <&pm8150_adc_tm 2>; ? Because the adctm reg properties above have values 0, 1 and 2.
There was a problem hiding this comment.
update in next patch-set
|
|
||
| &thermal_zones { | ||
| sys-therm-1 { | ||
| polling-delay-passive = <2000>; |
There was a problem hiding this comment.
Is this polling delay value correct? I think it is not needed for ADC_TM thermistors
There was a problem hiding this comment.
removed the polling delay values
Add PMIC topic overlay changes for Shikra SOM variants (CQM, CQS, IQS): - Add pm4125 temp-alarm and VADC channel nodes - Add pm8005 temp-alarm node - Add thermal zones for PMIC and system thermistors - Add GPIO key (volume up) bindings - Add ADC thermal bridge nodes for pa/quiet/msm thermistors - Disable pm8005 regulators across SOM variants - Switch SPMI interrupt to MPM edge-triggered Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
| qcom,hw-settle-time = <200>; | ||
| qcom,pre-scaling = <1 1>; | ||
| }; | ||
|
|
|
|
||
| pa-therm@0 { | ||
| reg = <0>; | ||
| io-channels = <&pm8150_adc ADC5_GPIO4_100K_PU>; |
There was a problem hiding this comment.
There is an extra space between &pm8150_adc and ADC5_GPIO4_100K_PU, remove it
2 participants
Add PMIC topic overlay changes for Shikra SOM variants (CQM, CQS, IQS):