Enable iface clock for kodiak and monaco ice sdhc#908
Open
kuld-sing wants to merge 2 commits intoqualcomm-linux:tech/security/icefrom
Open
Enable iface clock for kodiak and monaco ice sdhc#908kuld-sing wants to merge 2 commits intoqualcomm-linux:tech/security/icefrom
kuld-sing wants to merge 2 commits intoqualcomm-linux:tech/security/icefrom
Conversation
added 2 commits
April 8, 2026 00:08
Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. As bindings allow to specify 2 clocks, add iface clock now. Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Link: https://lore.kernel.org/linux-arm-msm/20260406-ice_emmc_clock_addition-v1-1-e7b237bf7a69@oss.qualcomm.com/ Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. As bindings allow to specify 2 clocks, add iface clock now. Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Link: https://lore.kernel.org/linux-arm-msm/20260406-ice_emmc_clock_addition-v1-2-e7b237bf7a69@oss.qualcomm.com/ Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
kuld-sing
force-pushed
the
tech/security/ice
branch
from
510df6f to
61b2782
Compare
arakshit011
reviewed
Apr 7, 2026
| reg = <0x0 0x007c8000 0x0 0x18000>; | ||
| clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>; | ||
| clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; | ||
| clock-names = "core", "iface"; |
arakshit011
reviewed
Apr 7, 2026
| reg = <0x0 0x087c8000 0x0 0x18000>; | ||
| clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>; | ||
| clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; | ||
| clock-names = "core", "iface"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As ice is now standalone driver decoupled from ufs driver.
MMC ice controller should also now specify iface clock alongwith core
clock.
The patchset is motivation to fix ice mmc where ice ufs is fixed with
below series.
https://lore.kernel.org/linux-arm-msm/20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com/T/#m5da5dd7a18318583b23ffeb42fa07ef1438042d5
Testing: