WORKAROUND: Use PWRSTS_RET_ON for USB GDSCs on Lemans and Monaco#281
Open
imrashai wants to merge 2 commits intoqualcomm-linux:qcom-6.18.yfrom
Open
WORKAROUND: Use PWRSTS_RET_ON for USB GDSCs on Lemans and Monaco#281imrashai wants to merge 2 commits intoqualcomm-linux:qcom-6.18.yfrom
imrashai wants to merge 2 commits intoqualcomm-linux:qcom-6.18.yfrom
Conversation
The USB GDSCs on SA8775P are currently configured with PWRSTS_OFF_ON, which allows the GDSC framework to fully collapse these power domains during gdsc_disable(). When these GDSCs collapse, the corresponding USB PHY configurations are not retained in USB host mode use-cases and this breaks the resume of USB controller from suspend. To avoid this, configure the USB GDSC power states to PWRSTS_RET_ON. This prevents the GDSC from powering off during gdsc_disable(), and allows hardware to retain the PHY configurations across USB host mode use-cases. Change-Id: If88c7f898b58650629144ab3ada0231afbc33bfe Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
The USB GDSCs on QCS8300 are currently configured with PWRSTS_OFF_ON, which allows the GDSC framework to fully collapse these power domains during gdsc_disable(). When these GDSCs collapse, the corresponding USB PHY configurations are not retained in USB host mode use-cases and this breaks the resume of USB controller from suspend. To avoid this, configure the USB GDSC power states to PWRSTS_RET_ON. This prevents the GDSC from powering off during gdsc_disable(), and allows hardware to retain the PHY configurations across USB host mode use-cases. Change-Id: I7ac4b6fec314c55be30b3a80c9bf8517528e99ec Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
imrashai
changed the title
Please add CRs-Fixed: in PR description. |
Author
Updated the CR details in PR description now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently USB team working on the actual fix to take care of keeping the GDSC ON during suspend use-case as per their requirement. This PR is a workaround to unblock the USB team.
CRs-Fixed: 4439827