Fix ICE reg size on Kodiak and SM8450 dts#440
Open
arakshit011 wants to merge 2 commits intoqualcomm-linux:qcom-6.18.yfrom
Open
Fix ICE reg size on Kodiak and SM8450 dts#440arakshit011 wants to merge 2 commits intoqualcomm-linux:qcom-6.18.yfrom
arakshit011 wants to merge 2 commits intoqualcomm-linux:qcom-6.18.yfrom
Conversation
The ICE register region on Kodiak is currently defined as 0x8000 bytes. According to the hardware specification, the correct register size is 0x18000. Update the ICE node reg property to match the hardware. Link: https://lore.kernel.org/linux-arm-msm/20260402-ice_dt_reg_fix-v1-1-74e4c2129238@oss.qualcomm.com/ Fixes: dfd5ee7 ("arm64: dts: qcom: sc7280: Add inline crypto engine") Reviewed-by: Harshal Dev <harshal.dev@oss.qualcomm.com> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
The ICE register region size was originally described incorrectly when the ICE hardware was first introduced. The same value was later carried over unchanged when the ICE node was split out from the UFS node into its own DT entry. Correct the register size to match the hardware specification. Link: https://lore.kernel.org/linux-arm-msm/20260402-ice_dt_reg_fix-v1-2-74e4c2129238@oss.qualcomm.com/ Fixes: 276ee34 ("arm64: dts: qcom: sm8450: add Inline Crypto Engine registers and clock") Reviewed-by: Harshal Dev <harshal.dev@oss.qualcomm.com> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
arakshit011
force-pushed
the
fix-reg-size
branch
from
5d74776 to
acd9fd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ICE reg size for kodiak and sm8450.
Ice reg size for kodiak/sm8450 is currently written incorrectly and
doesn't match hardware specification. This series attempt to fix it.
Link: https://lore.kernel.org/linux-arm-msm/20260402-ice_dt_reg_fix-v1-0-74e4c2129238@oss.qualcomm.com/
qcom-next PR: qualcomm-linux/kernel-topics#903
Signed-off-by: Kuldeep Singh kuldeep.singh@oss.qualcomm.com
Signed-off-by: Abhinaba Rakshit abhinaba.rakshit@oss.qualcomm.com
CRs-Fixed: 4495786