Skip to content

gst-sample-apps: Update package config and enable sample apps packaging#1530

Merged
lumag merged 2 commits intoqualcomm-linux:masterfrom
muthumul:test-meta-qcom-new
Mar 6, 2026
Merged

gst-sample-apps: Update package config and enable sample apps packaging#1530
lumag merged 2 commits intoqualcomm-linux:masterfrom
muthumul:test-meta-qcom-new

Conversation

@muthumul
Copy link
Copy Markdown
Contributor

This updates the IMSDK GStreamer plugin packaging and configuration to properly include the sample applications and ensure correct installation.

Comment thread recipes-multimedia/imsdk/gst-plugins-imsdk_git.bb Outdated
@ricardosalveti
Copy link
Copy Markdown
Contributor

Missing SoB / DCO.

@muthumul muthumul closed this Feb 19, 2026
@muthumul
Copy link
Copy Markdown
Contributor Author

Added a couple of more changes, will raise this on the latest changes.

@lumag lumag reopened this Feb 20, 2026
@lumag
Copy link
Copy Markdown
Contributor

lumag commented Feb 20, 2026

Please don't close the PRs just to add more changes

Comment thread recipes-multimedia/imsdk/gst-plugins-imsdk-packaging.inc
@ricardosalveti
Copy link
Copy Markdown
Contributor

Please rebase as there is now a conflict.

Copy link
Copy Markdown
Contributor

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: muthumul muthumul@qti.qualcomm.com

muthumul is not your name.

@muthumul muthumul force-pushed the test-meta-qcom-new branch 2 times, most recently from f7c313f to 8667de7 Compare February 24, 2026 08:19
@muthumul
Copy link
Copy Markdown
Contributor Author

muthumul commented Feb 24, 2026

Signed-off-by: muthumul muthumul@qti.qualcomm.com

muthumul is not your name.

I have updated it. Thank you for pointing it out.

@muthumul muthumul closed this Feb 24, 2026
@muthumul muthumul reopened this Feb 24, 2026
@muthumul
Copy link
Copy Markdown
Contributor Author

Sorry closed it by mistake.

@muthumul
Copy link
Copy Markdown
Contributor Author

Please rebase as there is now a conflict.

I have rebased the changes on the latest pull.

Comment thread recipes-multimedia/imsdk/gst-plugins-imsdk-packaging.inc Outdated
@anujm1
Copy link
Copy Markdown
Contributor

anujm1 commented Feb 24, 2026

sample-apps: add per-binary split packaging for sample-apps

The commit message should start with recipe-name:

Comment thread recipes-multimedia/imsdk/gst-plugins-imsdk-packaging.inc
Comment thread recipes-multimedia/imsdk/gst-plugins-imsdk_git.bb Outdated
@lumag
Copy link
Copy Markdown
Contributor

lumag commented Feb 24, 2026

Signed-off-by: muthumul muthumul@qti.qualcomm.com

muthumul is not your name.

I have updated it. Thank you for pointing it out.

Not completely:

From: muthumul muthumul@qti.qualcomm.com

@muthumul
Copy link
Copy Markdown
Contributor Author

Signed-off-by: muthumul muthumul@qti.qualcomm.com

muthumul is not your name.

I have updated it. Thank you for pointing it out.

Not completely:

From: muthumul muthumul@qti.qualcomm.com

I have updated in the signed-off-by, right? Can you please tell me where else I need to make this change? Thank you.

@ricardosalveti
Copy link
Copy Markdown
Contributor

sample-apps: add per-binary split packaging for sample-apps

The commit message should start with recipe-name:

You have 'sample-apps:', please use 'gst-plugins-imsdk:' instead.

Comment thread recipes-multimedia/imsdk/gst-plugins-imsdk_git.bb Outdated
Comment thread recipes-multimedia/imsdk/gst-plugins-imsdk_git.bb Outdated
@ricardosalveti
Copy link
Copy Markdown
Contributor

Hey @ricardosalveti This issue is fixed.

Not the right fix, this layer should't depend on meta-qcom-distro.

@muthumul muthumul force-pushed the test-meta-qcom-new branch from 27bfa97 to fdd3cbf Compare March 4, 2026 10:41
@muthumul
Copy link
Copy Markdown
Contributor Author

muthumul commented Mar 4, 2026

Hey everyone, webrtc sample app is removed from the mainline. So, we removed the webrtc dependency. later when it added back on, we will enable webrtc sample app separately in distro. This is also to clarify that we have around 20 AI based and 30 MM based sample apps. Out of which only one sample app is dependent on webrtc.

@muthumul
Copy link
Copy Markdown
Contributor Author

muthumul commented Mar 4, 2026

Another doubt that I had was that should we add ml plugins which are defined above as runtime dependencies? This is because our sample apps use these plugins with gst_element_factory_make? Right now, I am not facing any issue as such while running the sample apps. Tested it with QNN and SNPE plugins and they seem to be working fine. Any advice or suggestion on this matter?

@anujm1
Copy link
Copy Markdown
Contributor

anujm1 commented Mar 4, 2026

Hey everyone, webrtc sample app is removed from the mainline. So, we removed the webrtc dependency. later when it added back on, we will enable webrtc sample app separately in distro. This is also to clarify that we have around 20 AI based and 30 MM based sample apps. Out of which only one sample app is dependent on webrtc.

This will need SRCREV to be updated as well in a separate commit. Looking at the code, it looks like it will error out otherwise if webrtc is not present. Is this compiling for you without the SRCREV update?

@muthumul
Copy link
Copy Markdown
Contributor Author

muthumul commented Mar 4, 2026

Hey everyone, webrtc sample app is removed from the mainline. So, we removed the webrtc dependency. later when it added back on, we will enable webrtc sample app separately in distro. This is also to clarify that we have around 20 AI based and 30 MM based sample apps. Out of which only one sample app is dependent on webrtc.

This will need SRCREV to be updated as well in a separate commit. Looking at the code, it looks like it will error out otherwise if webrtc is not present. Is this compiling for you without the SRCREV update?

Thanks for pointing it out. I have bumped the SRCREV to include the latest source code changes: PR. With these changes, I have seen that the compilation isn't erroring out.

@anujm1
Copy link
Copy Markdown
Contributor

anujm1 commented Mar 4, 2026

Thanks for pointing it out. I have bumped the SRCREV to include the latest source code changes: PR. With these changes, I have seen that the compilation isn't erroring out.

Thanks. Please make sure to test your changes every time you push. Please rebase as well.

@muthumul muthumul force-pushed the test-meta-qcom-new branch from fdd3cbf to d053fec Compare March 5, 2026 07:41
@muthumul
Copy link
Copy Markdown
Contributor Author

muthumul commented Mar 5, 2026

Thanks for pointing it out. I have bumped the SRCREV to include the latest source code changes: PR. With these changes, I have seen that the compilation isn't erroring out.

Thanks. Please make sure to test your changes every time you push. Please rebase as well.

My bad. Will make it a point to do it hence forth.

@muthumul
Copy link
Copy Markdown
Contributor Author

muthumul commented Mar 5, 2026

After pulling the latest changes which include tflite and qmmfsrc, I have resolved the conflicts and pushed the code. Please let me know if there are any more changes or if we are good to go.

@muthumul
Copy link
Copy Markdown
Contributor Author

muthumul commented Mar 5, 2026

image

This is the error log in this build test:
image

This is the build which failed.

Can you please help me with this issue?

Comment thread recipes-multimedia/imsdk/gst-plugins-imsdk-packaging.inc Outdated
@muthumul muthumul force-pushed the test-meta-qcom-new branch from d053fec to ab0c276 Compare March 5, 2026 19:20
@anujm1
Copy link
Copy Markdown
Contributor

anujm1 commented Mar 6, 2026

@muthumul can you please rebase to fix CI failures?

muthumul added 2 commits March 6, 2026 18:39
…AGECONFIG

Added ${PN}-configs package to install sample app configuration files under ${sysconfdir}/configs/.
Introduced 'sample-apps' PACKAGECONFIG option in gst-plugins-imsdk to allow enabling sample applications
when required.

Signed-off-by: Muthumula Sai Harshith Reddy <muthumul@qti.qualcomm.com>
Enabled the sample-apps option in PACKAGECONFIG, but only when meta-oe is part of the layer stack.
This allows the sample applications to be built.

Signed-off-by: Muthumula Sai Harshith Reddy <muthumul@qti.qualcomm.com>
@muthumul muthumul force-pushed the test-meta-qcom-new branch from ab0c276 to e07bd05 Compare March 6, 2026 13:11
@muthumul
Copy link
Copy Markdown
Contributor Author

muthumul commented Mar 6, 2026

@muthumul can you please rebase to fix CI failures?

Hey @anujm1 I have done it

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

Test run workflow

Test jobs for commit e07bd05

Test qcs615-adp-air qcs6490 qcs8300 qcs9100 qcs9100-rb8 qrb2210-rb1
AudioRecord pass pass pass pass pass pass
BT_FW_KMD_Service fail pass pass pass pass pass
BT_ON_OFF ⚠️ skip pass pass pass pass pass
BT_SCAN ⚠️ skip pass pass pass pass pass
CPUFreq_Validation pass pass pass pass pass pass
DSP_AudioPD pass pass pass pass pass pass
Ethernet ⚠️ skip 🚫 pass pass pass ⚠️ skip
Interrupts pass pass pass pass pass pass
OpenCV pass pass pass pass pass pass
WiFi_Firmware_Driver pass pass pass pass pass pass
WiFi_OnOff ⚠️ skip pass pass pass pass pass
adsp_remoteproc pass pass pass pass pass pass
boot pass pass pass pass pass pass
cdsp_remoteproc pass pass pass pass pass ⚠️ skip
hotplug pass pass pass pass pass pass
irq pass pass pass pass pass pass

All jobs summary

Job ID Device State Health
155728 qcs6490 Finished Complete
155737 qcs9100 Finished Complete
155772 qcs615-adp-air Running Unknown
155757 qcs9100-rb8 Finished Complete
155727 qcs8300 Finished Complete
155742 qcs6490 Finished Complete
155729 qcs9100-rb8 Finished Complete
155738 qcs9100-rb8 Finished Complete
155765 qrb2210-rb1 Finished Complete
155748 qcs9100-rb8 Finished Complete
155761 qcs9100 Finished Complete
155743 qrb2210-rb1 Finished Complete
155755 qrb2210-rb1 Finished Complete
155766 qcs8300 Finished Complete
155756 qcs615-adp-air Finished Complete
155753 qcs9100-rb8 Finished Complete
155770 qcs6490 Finished Complete
155733 qcs9100 Finished Complete
155746 qcs6490 Finished Complete
155734 qrb2210-rb1 Finished Complete
155730 qrb2210-rb1 Finished Complete
155767 qcs9100-rb8 Finished Complete
155769 qcs6490 Finished Complete
155745 qcs615-adp-air Finished Complete
155735 qcs9100 Finished Complete
155771 qrb2210-rb1 Finished Complete
155751 qcs8300 Finished Complete
155762 qcs8300 Finished Complete
155773 qcs9100 Finished Complete
155758 qcs8300 Finished Complete
155749 qcs8300 Finished Complete
155740 qcs615-adp-air Finished Complete
155732 qcs8300 Finished Complete
155768 qcs615-adp-air Finished Complete
155774 qcs6490 Finished Complete
155759 qcs9100 Finished Complete
155754 qrb2210-rb1 Finished Complete
155750 qcs9100-rb8 Finished Complete
155739 qrb2210-rb1 Finished Complete
155764 qcs9100 Finished Complete
155736 qcs615-adp-air Finished Complete
155760 qcs615-adp-air Finished Incomplete
155741 qcs6490 Finished Complete
155752 qcs6490 Finished Complete
155744 qcs9100 Finished Complete
155731 qcs8300 Finished Complete
155747 qcs615-adp-air Finished Complete
155763 qcs9100-rb8 Finished Complete

@test-reporting-app
Copy link
Copy Markdown

Test Results

   47 files  +  1    209 suites  +2   3h 31m 2s ⏱️ + 50m 16s
   45 tests +  2     40 ✅  -   2   0 💤 ±0  5 ❌ +4 
2 063 runs  +113  2 046 ✅ +108  12 💤 +1  5 ❌ +4 

For more details on these failures, see this check.

Results for commit e07bd05. ± Comparison against base commit 57cbaaa.

@anujm1
Copy link
Copy Markdown
Contributor

anujm1 commented Mar 6, 2026

@lumag could you review this as well please since you had requested changes earlier?

@lumag lumag merged commit a94db2d into qualcomm-linux:master Mar 6, 2026
173 of 180 checks passed
@vkraleti vkraleti added this to the qli-2.0-rc2 milestone Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants