gst-sample-apps: Update package config and enable sample apps packaging#1530
gst-sample-apps: Update package config and enable sample apps packaging#1530lumag merged 2 commits intoqualcomm-linux:masterfrom
Conversation
|
Missing SoB / DCO. |
|
Added a couple of more changes, will raise this on the latest changes. |
|
Please don't close the PRs just to add more changes |
ac4ec83 to
0c32b9c
Compare
|
Please rebase as there is now a conflict. |
lumag
left a comment
There was a problem hiding this comment.
Signed-off-by: muthumul muthumul@qti.qualcomm.com
muthumul is not your name.
f7c313f to
8667de7
Compare
I have updated it. Thank you for pointing it out. |
|
Sorry closed it by mistake. |
I have rebased the changes on the latest pull. |
The commit message should start with |
Not completely:
|
I have updated in the signed-off-by, right? Can you please tell me where else I need to make this change? Thank you. |
You have 'sample-apps:', please use 'gst-plugins-imsdk:' instead. |
Not the right fix, this layer should't depend on meta-qcom-distro. |
27bfa97 to
fdd3cbf
Compare
|
Hey everyone, webrtc sample app is removed from the mainline. So, we removed the webrtc dependency. later when it added back on, we will enable webrtc sample app separately in distro. This is also to clarify that we have around 20 AI based and 30 MM based sample apps. Out of which only one sample app is dependent on webrtc. |
|
Another doubt that I had was that should we add ml plugins which are defined above as runtime dependencies? This is because our sample apps use these plugins with gst_element_factory_make? Right now, I am not facing any issue as such while running the sample apps. Tested it with QNN and SNPE plugins and they seem to be working fine. Any advice or suggestion on this matter? |
This will need SRCREV to be updated as well in a separate commit. Looking at the code, it looks like it will error out otherwise if webrtc is not present. Is this compiling for you without the SRCREV update? |
Thanks for pointing it out. I have bumped the SRCREV to include the latest source code changes: PR. With these changes, I have seen that the compilation isn't erroring out. |
Thanks. Please make sure to test your changes every time you push. Please rebase as well. |
fdd3cbf to
d053fec
Compare
My bad. Will make it a point to do it hence forth. |
|
After pulling the latest changes which include tflite and qmmfsrc, I have resolved the conflicts and pushed the code. Please let me know if there are any more changes or if we are good to go. |
d053fec to
ab0c276
Compare
|
@muthumul can you please rebase to fix CI failures? |
…AGECONFIG
Added ${PN}-configs package to install sample app configuration files under ${sysconfdir}/configs/.
Introduced 'sample-apps' PACKAGECONFIG option in gst-plugins-imsdk to allow enabling sample applications
when required.
Signed-off-by: Muthumula Sai Harshith Reddy <muthumul@qti.qualcomm.com>
Enabled the sample-apps option in PACKAGECONFIG, but only when meta-oe is part of the layer stack. This allows the sample applications to be built. Signed-off-by: Muthumula Sai Harshith Reddy <muthumul@qti.qualcomm.com>
ab0c276 to
e07bd05
Compare
Test run workflowTest jobs for commit e07bd05
All jobs summary
|
Test Results 47 files + 1 209 suites +2 3h 31m 2s ⏱️ + 50m 16s For more details on these failures, see this check. Results for commit e07bd05. ± Comparison against base commit 57cbaaa. |
|
@lumag could you review this as well please since you had requested changes earlier? |

This updates the IMSDK GStreamer plugin packaging and configuration to properly include the sample applications and ensure correct installation.