gst-plugins-imsdk: Enable qmmfsrc plugin by skomakul · Pull Request #1558 · qualcomm-linux/meta-qcom

skomakul · 2026-02-13T11:37:30Z

Added qmmfsrc to PACKAGECONFIG
This allows the plugin to be enabled when building gst-plugins-imsdk.

Excluded qmmfsrc from the opensource package group
The plugin relies on components that are not part of the public opensource deliverables.

Added qmmfsrc under dynamic-layers
The plugin depends on the client component, which internally depends on protobuf coming from the meta-openembedded layer.
Adding it to dynamic layers ensures correct layer ordering and dependency availability.

koenkooi · 2026-02-13T13:01:30Z

This does too much in a single commit, at a minimum the bbappend addition needs to be its own commit.

koenkooi

This does too much in a single commit, at a minimum the bbappend addition needs to be its own commit.

skomakul · 2026-02-18T06:41:58Z

This does too much in a single commit, at a minimum the bbappend addition needs to be its own commit.

Agreed, created separate commit for bbappend

lumag

Write commit messages as text rather than bullet lists

lumag

Added qmmfsrc to PACKAGECONFIG.
Excluded qmmfsrc from the opensource package group.

Don't describe what was done. Describe why it is done.

ricardosalveti · 2026-02-20T02:40:30Z

In your first commit you are not really enabling the plugin, you are adding the support to allow qmmfsrc to be built, so say that instead. Also, please explain what qmmfsrc actually does, in a short summary, to justify having it here.

In your second commit you are not really enabling in meta-openembedded, you can just say that you are enabling such PACKAGECONFIG by default, saying why and that it is done under dynamic-layers due the protobuf dependency.

lumag · 2026-02-20T11:50:36Z

It's not ready until we merge camera service

skomakul · 2026-03-03T06:53:08Z

updated the commit message please help to review.

anujm1 · 2026-03-03T07:43:30Z


 PACKAGECONFIG[messaging]    = "-DENABLE_GST_MESSAGING_PLUGINS=1, -DENABLE_GST_MESSAGING_PLUGINS=0, librdkafka mosquitto"
 PACKAGECONFIG[ml]           = "-DENABLE_GST_ML_PLUGINS=1, -DENABLE_GST_ML_PLUGINS=0, cairo json-glib opencv qairt-sdk, qairt-sdk"
+PACKAGECONFIG[qmmfsrc]      = "-DENABLE_GST_PLUGIN_QMMFSRC=1  -DVHDR_MODES_ENABLE=ON -DEIS_MODES_ENABLE=ON, -DENABLE_GST_PLUGIN_QMMFSRC=0 -DVHDR_MODES_ENABLE=OFF -DEIS_MODES_ENABLE=OFF, camera-service"


I don't see any EIS_MODES_ENABLE in gst-plugins-imsdk code. Where is it used?

My bad, recent code changes we changed it to get the info from static metadata. I will remove this flag

github-actions · 2026-03-03T14:05:44Z

Test run workflow

Test jobs for commit `5485dbb`

Test	qcs615-adp-air	qcs6490	qcs8300	qcs9100	qcs9100-rb8	qrb2210-rb1
boot	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass

All jobs summary

Job ID	Device	State	Health
153267	qcs6490	Finished	Complete
153276	qcs9100-rb8	Finished	Complete
153271	qcs8300	Finished	Complete
153265	qcs615-adp-air	Finished	Complete
153273	qcs6490	Finished	Complete
153286	qrb2210-rb1	Finished	Complete
153272	qcs8300	Finished	Complete
153278	qrb2210-rb1	Finished	Complete
153285	qcs6490	Finished	Complete
153280	qcs9100	Finished	Complete
153288	qrb2210-rb1	Finished	Complete
153284	qcs615-adp-air	Submitted	Unknown
153269	qcs615-adp-air	Finished	Complete
153283	qcs8300	Finished	Complete
153274	qcs9100	Finished	Complete
153279	qcs9100	Finished	Complete
153275	qcs615-adp-air	Running	Unknown
153266	qcs6490	Finished	Complete
153282	qcs9100-rb8	Finished	Complete
153277	qcs8300	Finished	Complete
153281	qcs9100-rb8	Finished	Complete
153270	qcs9100	Finished	Complete
153287	qrb2210-rb1	Finished	Complete
153268	qcs9100-rb8	Finished	Complete

test-reporting-app · 2026-03-03T14:06:17Z

Test Results

46 files + 22 193 suites +169 4h 2m 57s ⏱️ + 2h 45m 9s
45 tests + 36 40 ✅ + 35 0 💤 ±0 5 ❌ +1
1 923 runs +1 754 1 905 ✅ +1 740 9 💤 +9 9 ❌ +5

For more details on these failures, see this check.

Results for commit beff847. ± Comparison against base commit b062add.

♻️ This comment has been updated with latest results.

anujm1 · 2026-03-04T00:47:51Z

Second commit says:

Author: Kas User <kas@example.com>

Please fix. And while there, please also include the reason why qtiqmmfsrc is in IMSDK_OSS_METAPKG_EXCLUDE

ricardosalveti · 2026-03-04T00:49:42Z

Second commit says:

Author: Kas User <kas@example.com>

Nice catch, not obvious from the github interface.

ricardosalveti

Please fix your author line.

Add the support so that qmmfsrc GStreamer source plugin can be built as part of gst-plugins-imsdk. qmmfsrc helps to provide a high-performance camera capture source exposing advanced Qualcomm camera features. Excluded qmmfsrc from the opensource package group, since it depends on camera-service which is not present in opensource Signed-off-by: Shyam Komakula <skomakul@qti.qualcomm.com>

Enable the qmmfsrc PACKAGECONFIG by default so that platforms requiring the camera functionality gets the plugin built into the build. This is done under dynamic-layers due to the protobuf dependency. Signed-off-by: Shyam Komakula <skomakul@qti.qualcomm.com>

skomakul · 2026-03-04T05:51:11Z

Please fix your author line.

updated the author and added reason for excluding the qmmfsrc from opensource packaging. Please help to review.

github-actions · 2026-03-04T08:47:59Z

Test run workflow

Test jobs for commit `beff847`

Test	qcs615-adp-air	qcs6490	qcs8300	qcs9100	qcs9100-rb8	qrb2210-rb1
AudioRecord	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
BT_FW_KMD_Service	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
BT_ON_OFF	⚠️ skip	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
BT_SCAN	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
CPUFreq_Validation	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
DSP_AudioPD	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
Ethernet	⚠️ skip	🚫	✅ pass	⚠️ skip	✅ pass	⚠️ skip
Interrupts	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
OpenCV	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
WiFi_Firmware_Driver	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
WiFi_OnOff	⚠️ skip	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
adsp_remoteproc	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
boot	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
cdsp_remoteproc	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	⚠️ skip
hotplug	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
irq	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass

All jobs summary

Job ID	Device	State	Health
153735	qcs9100-rb8	Finished	Complete
153732	qcs8300	Finished	Complete
153736	qcs6490	Finished	Complete
153738	qcs9100-rb8	Finished	Complete
153737	qcs8300	Finished	Complete
153743	qcs9100	Finished	Complete
153742	qcs8300	Finished	Complete
153741	qcs9100-rb8	Finished	Complete
153727	qrb2210-rb1	Finished	Complete
153714	qrb2210-rb1	Finished	Complete
153713	qcs615-adp-air	Finished	Complete
153753	qrb2210-rb1	Finished	Complete
153723	qcs8300	Finished	Complete
153733	qcs9100-rb8	Finished	Complete
153731	qcs9100-rb8	Finished	Complete
153722	qcs6490	Finished	Complete
153719	qcs9100	Finished	Complete
153728	qrb2210-rb1	Finished	Complete
153740	qcs9100	Finished	Complete
153755	qrb2210-rb1	Finished	Complete
153720	qcs8300	Finished	Complete
153744	qcs9100-rb8	Finished	Incomplete
153734	qcs6490	Finished	Complete
153749	qcs615-adp-air	Finished	Complete
153750	qcs615-adp-air	Finished	Complete
153752	qcs6490	Finished	Complete
153725	qcs6490	Finished	Complete
153726	qcs615-adp-air	Finished	Complete
153712	qcs9100	Finished	Complete
153747	qcs9100	Finished	Complete
153739	qrb2210-rb1	Finished	Complete
153724	qcs615-adp-air	Finished	Complete
153710	qcs9100-rb8	Finished	Complete
153756	qcs615-adp-air	Running	Unknown
153716	qcs615-adp-air	Finished	Complete
153721	qcs8300	Finished	Complete
153746	qcs6490	Finished	Complete
153729	qcs9100	Finished	Complete
153718	qcs6490	Finished	Complete
153751	qrb2210-rb1	Finished	Complete
153754	qcs8300	Finished	Incomplete
153715	qcs9100	Finished	Complete
153730	qcs6490	Finished	Complete
153748	qcs9100	Finished	Complete
153757	qcs615-adp-air	Running	Unknown
153745	qcs8300	Finished	Complete
153717	qrb2210-rb1	Finished	Complete
153711	qcs9100-rb8	Finished	Complete

koenkooi requested changes Feb 13, 2026

View reviewed changes

muralibell mentioned this pull request Feb 13, 2026

camera-service: Add recipes for Qualcomm Linux Embedded Camera Service. #1501

Merged

skomakul force-pushed the qmmfsrc_enable branch 2 times, most recently from e8772bc to 33ccd39 Compare February 18, 2026 06:40

lumag requested changes Feb 18, 2026

View reviewed changes

skomakul force-pushed the qmmfsrc_enable branch from ac25a57 to 1101ee5 Compare February 19, 2026 08:37

lumag reviewed Feb 19, 2026

View reviewed changes

ricardosalveti marked this pull request as ready for review February 20, 2026 02:40

ricardosalveti requested review from ndechesne, ricardosalveti, sbanerjee-quic and vkraleti as code owners February 20, 2026 02:40

lumag marked this pull request as draft February 20, 2026 11:50

skomakul force-pushed the qmmfsrc_enable branch from 1101ee5 to 577c9ec Compare March 3, 2026 06:49

anujm1 reviewed Mar 3, 2026

View reviewed changes

skomakul force-pushed the qmmfsrc_enable branch from 577c9ec to 5485dbb Compare March 3, 2026 08:08

skomakul marked this pull request as ready for review March 3, 2026 11:38

ricardosalveti approved these changes Mar 3, 2026

View reviewed changes

ricardosalveti requested changes Mar 4, 2026

View reviewed changes

skomakul force-pushed the qmmfsrc_enable branch from 5485dbb to 08a3d69 Compare March 4, 2026 05:20

skomakul force-pushed the qmmfsrc_enable branch from 08a3d69 to beff847 Compare March 4, 2026 05:49

anujm1 approved these changes Mar 4, 2026

View reviewed changes

lumag approved these changes Mar 4, 2026

View reviewed changes

lumag requested review from koenkooi and ricardosalveti March 4, 2026 08:44

ricardosalveti approved these changes Mar 4, 2026

View reviewed changes

ricardosalveti merged commit 3b2c2c8 into qualcomm-linux:master Mar 4, 2026
168 of 171 checks passed

Conversation

skomakul commented Feb 13, 2026

Uh oh!

koenkooi commented Feb 13, 2026

Uh oh!

koenkooi left a comment

Choose a reason for hiding this comment

Uh oh!

skomakul commented Feb 18, 2026

Uh oh!

lumag left a comment

Choose a reason for hiding this comment

Uh oh!

lumag left a comment

Choose a reason for hiding this comment

Uh oh!

ricardosalveti commented Feb 20, 2026

Uh oh!

lumag commented Feb 20, 2026

Uh oh!

skomakul commented Mar 3, 2026

Uh oh!

anujm1 Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

skomakul Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 3, 2026

Test run workflow

Test jobs for commit 5485dbb

All jobs summary

Uh oh!

test-reporting-app Bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

anujm1 commented Mar 4, 2026

Uh oh!

ricardosalveti commented Mar 4, 2026

Uh oh!

ricardosalveti left a comment

Choose a reason for hiding this comment

Uh oh!

skomakul commented Mar 4, 2026

Uh oh!

github-actions Bot commented Mar 4, 2026

Test run workflow

Test jobs for commit beff847

All jobs summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Test jobs for commit `5485dbb`

test-reporting-app Bot commented Mar 3, 2026 •

edited

Loading

Test jobs for commit `beff847`