sm8750-mtp.conf: add boot firmware for SM8750-MTP#1635
sm8750-mtp.conf: add boot firmware for SM8750-MTP#1635ricardosalveti merged 3 commits intoqualcomm-linux:masterfrom
Conversation
vivpuar
requested review from
anujm1,
koenkooi,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
vivpuar
force-pushed
the
sm8750-meta-qcom_git
branch
from
51eb049 to
2fe70e9
Compare
| BOOTBINARIES = "pakala_bootbinaries" | ||
|
|
||
| SRC_URI = " \ | ||
| https://${FW_ARTIFACTORY}/${FW_BUILD_ID}/${FW_BIN_PATH}/${BOOTBINARIES}.zip;downloadfilename=${BOOTBINARIES}_r0.0_${PV}.zip;name=bootbinaries \ |
There was a problem hiding this comment.
We need to align this with #1633, otherwise it will create a mess with the versioning number used.
The recipe has 00008.0 as version but it is released under r0.0. Current firmware in meta-qcom is based on r1.0 and the one proposed in 1633 is r2.0 based.
We need to bring some sanity here.
There was a problem hiding this comment.
K,L,M,T are on SPF 1.0 which is soon transitioning to SPF 2.0 as part of QLI 2.x releases. Where as Pakala and Glymur are not planned for QLI 2.0. They remain on SPF 0.0 and continue to support via mainline. Hence the mimatch.
I am checking with Target team is there is a possibility to support all targets from same SPF line.
There was a problem hiding this comment.
I think I'm fine with the firmware coming form different locations on the server, if the versions are properly aligned.
There was a problem hiding this comment.
Yeah, no need to support the same SPF necessarily, we just need some sanity with the versions used here, and it should be reflected in the recipe as PV.
So this version is really 0.0.00008.0 in the end.
There was a problem hiding this comment.
Distribution tools team confirmed about moving to a generic artifacts URL in a few weeks. Till then, boot-bins continue to be delivered in existing SPF specific URLs. For sm8750, this PR updated version as _00008.0. Is it fine? Or should it be changed to 0.0_00008.0?
There was a problem hiding this comment.
What will be the version used with generic artifacts?
There was a problem hiding this comment.
@vkraleti what's the "generic artifacts URL"? 0.0? Something else?
There was a problem hiding this comment.
The tentative proposal is to organize boot_bins as
https://softwarecenter.qualcomm.com/nexus/generic/software/chip/boot_bins/qualcomm_linux/
QCS6490/
QCM6490_bootbinaries_000114.0.zip
QCM6490_bootbinaries_000116.0.zip
QCS9100/
QCS9100_bootbinaries_000114.0.zip
QCS9100_bootbinaries_000116.0.zip
.
.
.
HAMOA/
HAMOA_bootbinaries_00001.0.zip
PAKALA/
PAKALA_bootbinaries_00003.0.zip
GLYMUR/
GLYMUR_bootbinaries_00009.0.zip
Managing the versioning of these zips while the products transitioning from one SPF to another like 1.x -> 2.x -> 3.x is still under discussion.
There was a problem hiding this comment.
We need the concept of stable releases (with minor updates) for LTS releases, or we move mainline forward and just backport the changes.
vivpuar
force-pushed
the
sm8750-meta-qcom_git
branch
from
2fe70e9 to
b6a61a4
Compare
Test run workflowTest jobs for commit b6a61a4
All jobs summary
|
Test Results 17 files - 3 17 suites - 3 1h 51m 4s ⏱️ + 1h 24m 26s For more details on these failures, see this check. Results for commit dc31a78. ± Comparison against base commit 8f9cf91. ♻️ This comment has been updated with latest results. |
|
Please rebase to fix conflicts. |
This recipe fetches and installs the boot firmware and CDT to generate flat build for SM8750-MTP board. Signed-off-by: Vivek Puar <vpuar@qti.qualcomm.com>
SM8750-MTP uses xbl_s_devprg_ns.melf as device programmer while flashing, and xbl_s.melf file is flashed in xbl partiiton. Including these files in the qcomflash directory. Signed-off-by: Vivek Puar <vpuar@qti.qualcomm.com>
Add boot firmware support for SM8750-MTP board, systemd-boot is enabled so drop ABL_SIGNATURE_VERSION definition from machine as we no longer need to use abl2esp.elf file during boot. Signed-off-by: Vivek Puar <vpuar@qti.qualcomm.com>
vivpuar
force-pushed
the
sm8750-meta-qcom_git
branch
from
b6a61a4 to
dc31a78
Compare
Done |
Test run workflowTest jobs for commit dc31a78
All jobs summary
|
ricardosalveti
merged commit b003e51
into
qualcomm-linux:master
4 participants
Add boot firmware recipe and include in machine conf
systemd-boot is enabled, so drop ABL_SIGNATURE_VERSION definition from machine conf as we no longer need to use abl2esp.elf file during boot.
SM8750-MTP uses xbl_s_devprg_ns.melf as device programmer while flashing, and xbl_s.melf file is flashed in xbl partiiton, so include *.melf files in image_types_qcom.bbclass