dtb-fit-image: fix do_generate_qcom_fitimage[vardeps]#1638
Merged
ricardosalveti merged 1 commit intoqualcomm-linux:masterfrom Feb 26, 2026
Merged
dtb-fit-image: fix do_generate_qcom_fitimage[vardeps]#1638ricardosalveti merged 1 commit intoqualcomm-linux:masterfrom
ricardosalveti merged 1 commit intoqualcomm-linux:masterfrom
Conversation
quaresmajose
requested review from
anujm1,
koenkooi,
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
Contributor
Author
|
More context in #1618 (comment) |
Contributor
|
@quaresmajose please clean up your git commit message, no need to dump the variables, also please break lines to the 80 columns max. |
Contributor
|
When I proposed #1618 it didn't work when testing locally, but I extended one variable locally again (not removing it, as that would cause cache to be invalidated) and it worked correctly, so fine with the change. |
Test run workflowTest jobs for commit 90d45d2
All jobs summary
|
Test Results 47 files + 16 106 suites +75 3h 35m 31s ⏱️ + 2h 12m 39s For more details on these failures, see this check. Results for commit e2b721b. ± Comparison against base commit 0362862. ♻️ This comment has been updated with latest results. |
2b272aa add the FIT_DTB_COMPATIBLE in task signature parsing all the keys and values of the variable. But we can use the FIT_DTB_COMPATIBLE directly on the vardeps of the qcom_generate_qcom_fitimage task. This was tested building linux-qcom-next and afer that removing one element from FIT_DTB_COMPATIBLE[...] = ...' then looking at the signatures and the change is caught by bitbake. | Task linux-qcom-next:do_generate_qcom_fitimage couldn't be used from the cache because: | ... | changed items: frozenset({'FIT_DTB_COMPATIBLE[talos-evk+talos-evk-lvds-auo_g133han01]'}) | Dependency on Variable FIT_DTB_COMPATIBLE[talos-evk+talos-evk-lvds-auo_g133han01] was removed Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
quaresmajose
force-pushed
the
dtb-fit-image
branch
from
90d45d2 to
e2b721b
Compare
Contributor
Author
Also check when we don't remove the element:
--- a/conf/machine/include/fit-dtb-compatible.inc
+++ b/conf/machine/include/fit-dtb-compatible.inc
@@ -109,4 +109,4 @@ FIT_DTB_COMPATIBLE[sm8450-hdk] = "qcom,sm8450-hdk"
FIT_DTB_COMPATIBLE[sm8750-mtp] = "qcom,sm8750-mtp"
FIT_DTB_COMPATIBLE[talos-evk+talos-evk-camera-imx577] = "qcom,qcs615v1.1-iot"
FIT_DTB_COMPATIBLE[talos-evk+talos-evk-camx] = "qcom,qcs615v1.1-iot-camx"
-FIT_DTB_COMPATIBLE[talos-evk+talos-evk-lvds-auo_g133han01] = "qcom,talos-evk-lvds-auo,g133han01"
+FIT_DTB_COMPATIBLE[talos-evk+talos-evk-lvds-auo_g133han01-] = "qcom,talos-evk-lvds-auo,g133han01"and the signature
--- a/conf/machine/include/fit-dtb-compatible.inc
+++ b/conf/machine/include/fit-dtb-compatible.inc
@@ -109,4 +109,4 @@ FIT_DTB_COMPATIBLE[sm8450-hdk] = "qcom,sm8450-hdk"
FIT_DTB_COMPATIBLE[sm8750-mtp] = "qcom,sm8750-mtp"
FIT_DTB_COMPATIBLE[talos-evk+talos-evk-camera-imx577] = "qcom,qcs615v1.1-iot"
FIT_DTB_COMPATIBLE[talos-evk+talos-evk-camx] = "qcom,qcs615v1.1-iot-camx"
-FIT_DTB_COMPATIBLE[talos-evk+talos-evk-lvds-auo_g133han01] = "qcom,talos-evk-lvds-auo,g133han01"
+FIT_DTB_COMPATIBLE[talos-evk+talos-evk-lvds-auo_g133han01] = "qcom,talos-evk-lvds-auo,g133han01-"
and the signature |
ricardosalveti
approved these changes
Feb 26, 2026
lumag
approved these changes
Feb 26, 2026
Test run workflowTest jobs for commit e2b721b
All jobs summary
|
Test run workflowTest jobs for commit e2b721b
All jobs summary
|
ricardosalveti
merged commit c93093b
into
qualcomm-linux:master
220 of 227 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2b272aa add the FIT_DTB_COMPATIBLE in task signature parsing all the keys
and values of the variable. But we can use the FIT_DTB_COMPATIBLE directly
on the vardeps of the qcom_generate_qcom_fitimage task.
This was tested building linux-qcom-next and afer that
removing one element from FIT_DTB_COMPATIBLE[...] = ...'
then looking at the signatures and the change is caught by bitbake.
| Task linux-qcom-next:do_generate_qcom_fitimage couldn't be used from the cache because:
| ...
| changed items: frozenset({'FIT_DTB_COMPATIBLE[talos-evk+talos-evk-lvds-auo_g133han01]'})
| Dependency on Variable FIT_DTB_COMPATIBLE[talos-evk+talos-evk-lvds-auo_g133han01] was removed