Skip to content

CI: test: download build URLs from the correct GitHub run#1639

Merged
ricardosalveti merged 1 commit intoqualcomm-linux:masterfrom
lumag:rework-ci
Feb 25, 2026
Merged

CI: test: download build URLs from the correct GitHub run#1639
ricardosalveti merged 1 commit intoqualcomm-linux:masterfrom
lumag:rework-ci

Conversation

@lumag
Copy link
Copy Markdown
Contributor

@lumag lumag commented Feb 25, 2026

Before the commit 06b45e2 ("CI: test: stop downloading artifacts one more time") all build URLs were attempted to be downloaded twice, once in test.yml and once in the list-jobs/action.yml.

The commit dropped artifact downloading from test.yml, deferring all downloads to the list-jobs action, however the workflow passes the calling build id to the action rather than the current one, ending up with the list-jobs not finding any build URLs (because it tries to download them from the build run rather than the test run).

The issue didn't manifest in the 'Build on Push' workflows because the the build run and the test run are the same.

Fixes: 06b45e2 ("CI: test: stop downloading artifacts one more time")

Before the commit 06b45e2 ("CI: test: stop downloading artifacts
one more time") all build URLs were attempted to be downloaded twice,
once in test.yml and once in the list-jobs/action.yml.

The commit dropped artifact downloading from test.yml, deferring all
downloads to the list-jobs action, however the workflow passes the
calling build id to the action rather than the current one, ending up
with the list-jobs not finding any build URLs (because it tries to
download them from the build run rather than the test run).

The issue didn't manifest in the 'Build on Push' workflows because the
the build run and the test run are the same.

Fixes: 06b45e2 ("CI: test: stop downloading artifacts one more time")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
@lumag lumag requested a review from mwasilew February 25, 2026 16:34
@mwasilew
Copy link
Copy Markdown
Contributor

I think this can't work. In test-pr.yml the ID of the build workflow is passed and list-jobs should use it to download build URL files. If you change it to the current workflow ID list-jobs won't be able to find the build URL files. Let me try it on the side.

@lumag
Copy link
Copy Markdown
Contributor Author

lumag commented Feb 25, 2026

I think this can't work. In test-pr.yml the ID of the build workflow is passed and list-jobs should use it to download build URL files. If you change it to the current workflow ID list-jobs won't be able to find the build URL files. Let me try it on the side.

It is exactly what is happening currently. See https://github.com/qualcomm-linux/meta-qcom/actions/runs/22369019310/job/64742705506 for example:

Run actions/download-artifact@v7
  with:
    github-token: ***
    run-id: 22340700762
    pattern: boottest*
    merge-multiple: false
    repository: qualcomm-linux/meta-qcom
Fetching artifact list for workflow run 22340700762 in repository qualcomm-linux/meta-qcom

Note that the run-id is wrong and it belongs to the build workflow.

@ricardosalveti
Copy link
Copy Markdown
Contributor

Will merge as an attempt to get this behavior fixed, as all our current prs are on hold due this issue.

@ricardosalveti ricardosalveti merged commit 61bbe21 into qualcomm-linux:master Feb 25, 2026
168 checks passed
@mwasilew
Copy link
Copy Markdown
Contributor

There is a different issue - a typo in list-files action. I'll send a PR in a moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants