added coresight helper(utils) and sink-source-test#389
Open
Rohan-in-Qualcomm wants to merge 1 commit intoqualcomm-linux:mainfrom
Open
added coresight helper(utils) and sink-source-test#389Rohan-in-Qualcomm wants to merge 1 commit intoqualcomm-linux:mainfrom
Rohan-in-Qualcomm wants to merge 1 commit intoqualcomm-linux:mainfrom
Conversation
Rohan-in-Qualcomm
force-pushed
the
debug-smmu
branch
from
4de3cdb to
22a4348
Compare
Contributor
|
@Rohan-in-Qualcomm This PR is too large for a clean review in its current form. It is 1 commit / 19 files and bundles a shared helper plus 6 different CoreSight suites. It also mixes repeated YAML/orchestration issues with runner-specific correctness bugs, which makes it hard to review and hard to rework safely. Please split this into smaller PRs. Suggested grouping:
Also please update the PR title/body to match the actual scope. This is a CoreSight debug-suite PR, not an SMMU PR. After the split, the file-level issues will be much easier to review cleanly. |
vnarapar
reviewed
Apr 7, 2026
Runner/suites/Kernel/DEBUG/Single-Sink-Reset-Connected-Base/run.sh
Outdated
Show resolved
Hide resolved
Rohan-in-Qualcomm
force-pushed
the
debug-smmu
branch
2 times, most recently
from
fc727ca to
61c81a2
Compare
Rohan-in-Qualcomm
changed the title
Signed-off-by: Rohan Dutta <rohadutt@qti.qualcomm.com>
Rohan-in-Qualcomm
force-pushed
the
debug-smmu
branch
from
61c81a2 to
8f852a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also a common library helper function coresight_helper.sh is added to prevent duplication of code blocks.