Open
Conversation
rdettai-sk
force-pushed
the
imp-search-metrics-logs
branch
from
b6e89c6 to
4068e65
Compare
| .with_label_values(label_values) | ||
| .inc(); | ||
| SEARCH_METRICS | ||
| .root_search_request_duration_seconds |
Collaborator
There was a problem hiding this comment.
but this is just the planning part isn't it?
Collaborator
There was a problem hiding this comment.
I don't understand, you are recording this in a metric that is used for something else?
Collaborator
Author
There was a problem hiding this comment.
this is recorded here only if the planning failed (error or cancellation), this function returns early in case of success
// this is a partial success, actual status will be recorded during the search step
Some(true) => return,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve search metrics to account for partial success and log errors.
How was this PR tested?
Describe how you tested this PR.