fix: Support datetime with timezone and with millis#6107
Open
Darkheir wants to merge 2 commits intoquickwit-oss:mainfrom
Open
fix: Support datetime with timezone and with millis#6107Darkheir wants to merge 2 commits intoquickwit-oss:mainfrom
Darkheir wants to merge 2 commits intoquickwit-oss:mainfrom
Conversation
Signed-off-by: Darkheir <raphael.cohen@sekoia.io>
rdettai-sk
approved these changes
Jan 21, 2026
Collaborator
rdettai-sk
left a comment
There was a problem hiding this comment.
This is still not ISO 8601 compliant but definitively better. I also noticed that
- there doesn't seem to be a difference between
yyyy-MM-dd['T'HH[:mm[:ss[.SSS][Z]]]]andyyyy-MM-dd['T'HH[:mm[:ss[.SSSSS][Z]]]] - I think it should be strict_date_optional_time that forces yyyy-MM-dd and date_optional_time that has it optional
Contributor
Author
It is complicated to find a good reference about the behavior inside Elasticsearch, but in their documentation it is written
So there is nothing about the month and the days being mandatory or not... I think that in both cases we should allow to have only the year or the year and the month. |
Signed-off-by: Darkheir <raphael.cohen@sekoia.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for datetimes without milliseconds or nanoseconds with a timezone set as it is supported by Elasticsearch.
The PR makes also
date_optional_timeandstrict_date_optional_time_nanosmore lenient with minutes and seconds as it was already the case forstrict_date_optional_time.How was this PR tested?
Unit tests