[phase-31 2/4] Compaction metadata types#6243
Merged
g-talbot merged 0 commit intogtt/phase-31-sort-schemafrom Mar 31, 2026
Merged
[phase-31 2/4] Compaction metadata types#6243g-talbot merged 0 commit intogtt/phase-31-sort-schemafrom
g-talbot merged 0 commit intogtt/phase-31-sort-schemafrom
Conversation
7 tasks
f2a45ef to
ff1b561
Compare
c012908 to
780c585
Compare
ff1b561 to
db1641a
Compare
780c585 to
08577b5
Compare
db1641a to
ad63f91
Compare
955f230 to
3e73d80
Compare
366dd33 to
a64ddaf
Compare
3e73d80 to
2f78fe8
Compare
2f78fe8 to
2703ca5
Compare
a64ddaf to
2703ca5
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend MetricsSplitMetadata with 6 compaction fields and update PostgreSQL model types (Phase 31 Metadata Foundation, PR 2 of 4).
Stacks on
gtt/phase-31-sort-schema(PR #6242).What's included
split/metadata.rs:
MetricsSplitMetadata:window_start,window_duration_secs,sort_fields,num_merge_ops,row_keys_proto,zonemap_regexesparquet_files: Vec<String>field (replaces single-file assumption)debug_assert!invariants from ADR-003split/postgres.rs:
InsertableMetricsSplitandPgMetricsSplitfrom_metadata()populates new SQL columnsschema/fields.rs:
ParquetField::from_name()for name-based field lookup (used by sort field resolver)Verification
cargo build -p quickwit-parquet-engine✅cargo test -p quickwit-parquet-engine -- split::metadata split::postgres✅ (11 tests)cargo clippy -p quickwit-parquet-engine --all-features --tests✅Test plan
🤖 Generated with Claude Code