feat: support driver.DriverContext interface#44
Open
conradludgate wants to merge 1 commit intoqustavo:masterfrom
Open
feat: support driver.DriverContext interface#44conradludgate wants to merge 1 commit intoqustavo:masterfrom
conradludgate wants to merge 1 commit intoqustavo:masterfrom
Conversation
Owner
|
Hey @conradludgate thanks for doing this, it looks like a great contribution! |
Author
Sure! I'll look into it later |
Collaborator
|
This PR is quite old, removing myself from the reviewer list. Feel free to add me back if you ever get around to qustavo's feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sql.Openinternally makes use of theDriverContextinterface, and if aDriverdoes not implement it, it creates a light wrapper1.This
DriverContextprovides better context support as well as providing some useful error checking upfront. For instance, themysqldriver can check theDSNvalue before opening a connection to see if it's well formed. That way you get an error instantly instead of an error when making your first sql query1: https://github.com/golang/go/blob/d0dd26a88c019d54f22463daae81e785f5867565/src/database/sql/sql.go#L832 https://github.com/golang/go/blob/d0dd26a88c019d54f22463daae81e785f5867565/src/database/sql/sql.go#L755-L766