Update postgresHasDefault() error message to document libpq defaults#553
Draft
Update postgresHasDefault() error message to document libpq defaults#553
Conversation
Update documentation to accurately reflect libpq's full default chain: - dbname: mention PGDATABASE env var, then fallback to user name - user: add OS username fallback when PGUSER is not set - host,port: add libpq defaults (Unix socket, port 5432) when env vars unset - service: add PGSERVICE env var mention - postgresHasDefault(): clarify not all env vars are required Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Align postgresDefault() with other Postgres libraries
Align postgresDefault() docs with libpq defaults
Feb 21, 2026
…ssage Per reviewer feedback, dbConnect should remain fully deterministic. Only the postgresHasDefault() error message in default.R is updated to clarify libpq defaults. All changes to dbConnect_PqDriver.R and generated man pages are reverted. Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Contributor
Author
Reverted all |
Copilot
AI
changed the title
Align postgresDefault() docs with libpq defaults
Update postgresHasDefault() error message to document libpq defaults
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
postgresHasDefault()error message previously implied allPG*env vars must be defined. Updated to clarify that libpq has sensible defaults and env vars are optional overrides.postgresHasDefault()error messageOld message stated users must define
PGHOST,PGPORT,PGUSER,PGPASSWORD, andPGDATABASE. Updated to clarify:No changes to
dbConnect()— it remains fully deterministic.Original prompt
postgresDefault()with other Postgres libraries #552🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.