Skip to content

feat: have enrol configure DNS and NTP on our BMCs #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevekeay wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: have enrol configure DNS and NTP on our BMCs #1700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 33 additions & 19 deletions python/understack-workflows/understack_workflows/bmc_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,29 @@
import logging
import os

from understack_workflows.bmc import Bmc

logger = logging.getLogger(__name__)

# When we read Enum-type keys we can expect a string like "Enabled".
#
# To change that key requires the numeric new_value string like "1".
STANDARD = {
"SNMP.1.AgentEnable": {"expect": "Enabled", "new_value": "1"},
"SNMP.1.SNMPProtocol": {"expect": "All", "new_value": "0"},
"SNMP.1.AgentCommunity": {"expect": "public", "new_value": "public"},
"SNMP.1.AlertPort": {"expect": 161, "new_value": 161},
"SwitchConnectionView.1.Enable": {"expect": "Enabled", "new_value": "Enabled"},
REQUIRED_VALUES = {
"SNMP.1.AgentEnable": "Enabled",
"SNMP.1.SNMPProtocol": "All",
"SNMP.1.AgentCommunity": "public",
"SNMP.1.AlertPort": 161,
"SwitchConnectionView.1.Enable": "Enabled",
"NTPConfigGroup.1.NTPEnable": "Enabled",
"Time.1.Timezone": "Zulu",
Copy link
Collaborator

@skrobul skrobul Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

"IPv4.1.DNS1": os.getenv("DNS_SERVER_IPV4_ADDR_1"),
"IPv4.1.DNS2": os.getenv("DNS_SERVER_IPV4_ADDR_2"),
"NTPConfigGroup.1.NTP1": os.getenv("NTP_SERVER_IPV4_ADDR_1"),
"NTPConfigGroup.1.NTP2": os.getenv("NTP_SERVER_IPV4_ADDR_2"),
}

# When we GET Enum-type keys we can expect a string like "Enabled".
# To change that key requires us to POST the numeric string like "1".
VALUES_TO_POST = REQUIRED_VALUES | {
"SNMP.1.AgentEnable": "1",
"SNMP.1.SNMPProtocol": "0",
}


Expand All @@ -28,20 +39,23 @@ def update_dell_drac_settings(bmc: Bmc) -> dict:
attribute_path = bmc.manager_path + "/Attributes"
current_values = bmc.redfish_request(attribute_path)["Attributes"]

for key, _value in STANDARD.items():
if key not in current_values:
raise BiosSettingException(f"{bmc} has no BMC attribute {key}")

required_changes = {
k: x["new_value"]
for k, x in STANDARD.items()
if current_values[k] != x["expect"]
}
required_changes = {}
for key, required_value in REQUIRED_VALUES.items():
if not required_value:
logger.warning(
"We have no required value configured for BMC attribute '%s'", key
)
elif key not in current_values:
logger.warning("%s has no BMC attribute '%s'", bmc, key)
elif current_values[key] == required_value:
logger.warning("%s: '%s' already set to '%s'", bmc, key, required_value)
else:
required_changes[key] = VALUES_TO_POST[key]

if required_changes:
logger.info("%s Updating DRAC settings:", bmc)
for k in required_changes.keys():
logger.info(" %s: %s->%s", k, current_values[k], STANDARD[k]["expect"])
logger.info(" %s: %s->%s", k, current_values[k], REQUIRED_VALUES[k])

payload = {"Attributes": required_changes}
bmc.redfish_request(attribute_path, payload=payload, method="PATCH")
Expand Down
Loading