add code to parse content-disposition headers per RFC6266#16
Open
jbclements wants to merge 3 commits intoracket:masterfrom
Open
add code to parse content-disposition headers per RFC6266#16jbclements wants to merge 3 commits intoracket:masterfrom
jbclements wants to merge 3 commits intoracket:masterfrom
Conversation
Contributor
|
I'm very happy that you did it and that it works. I'm very anxious because of the big change and yet-another-parser library. There is a test suite, but I think it might be wise to solicit some tests from users of different browsers. I'm not trying to be a pain but I'm just trying to be conservative in this way. |
Contributor
Author
|
I totally agree... I know plenty of Mozilians, let me see what I can do. |
jbclements
force-pushed
the
add-content-disposition-header-parsing
branch
from
b3dae0a to
8e47976
Compare
Contributor
|
We've been sitting on this for a long time. Any updates on the testing worry? |
jbclements
force-pushed
the
add-content-disposition-header-parsing
branch
from
8e47976 to
29498e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, that was a bit more unpleasant than expected. Lots of RFC-reading involved, and implementation of a teeny tiny parser combinator framework.
Also, what's our policy on unit tests? This pull request has a bunch of them.