Open
Conversation
- src/index.mjs: add ozone-platform-hint=auto for Linux before app.whenReady() so all instances (including rnio:// deep-link second-instances) auto-select Wayland or fall back to X11 — no manual --ozone-platform flag needed. - build/config.js: change Linux target from [snap] to [AppImage, deb, snap]; add snap plugs (x11, wayland, desktop-legacy, opengl, home, network, browser-support) so the snap version works without manual plug connections. - build/version.mjs: fix import.meta.dirname → fileURLToPath pattern for Node 18 compatibility (import.meta.dirname requires Node >=20.11). - build/webapp.js: skip webapp rebuild when dist already present; pass empty SENTRY_AUTH_TOKEN so Sentry CLI plugin degrades gracefully on local builds. - .github/workflows/linux.yml: upload AppImage and deb as CI artifacts alongside the existing Snap Store publish step. - build.sh: convenience build script for local Linux builds. - RAINDROP-REPORT.md: analysis, changes, build instructions, binary path. Upstream changes merged: raindropio/desktop@4601c1a (webapp submodule update). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
AppImages built by electron-builder require libfuse2, which is absent on Ubuntu 22.04+ (only libfuse3 is present by default). Rather than installing libfuse2, use the .deb package as the recommended artifact on Ubuntu/Debian. - build.sh: replace AppImage run hint with 'sudo dpkg -i' command; add note that AppImage requires libfuse2. - RAINDROP-REPORT.md: make deb the recommended binary; add Known Issues section documenting the libfuse2 requirement. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…elease - README.md: add Ubuntu/Linux build section with prerequisites, build.sh usage, dpkg install command, and libfuse2 note. - linux.yml: trigger on master (in addition to release/production); use --publish always so electron-builder creates a GitHub Release draft and attaches the .deb; remove Snapcraft publish step; keep deb artifact upload. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add permissions: contents: write (required for GITHUB_TOKEN to create releases) - Add workflow_dispatch trigger (allows manual runs from Actions tab) - Upgrade actions/checkout to v4 and actions/setup-node to v4 - Remove SENTRY_AUTH_TOKEN env (not needed, webapp build skips when dist exists) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The webapp's webpack config includes a Sentry CLI plugin that exits non-zero when SENTRY_AUTH_TOKEN is missing. The dist files are still produced despite the error. Catch the error, verify dist/electron/prod/index.html exists, and continue the build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- package.json: change repository URL to 0xTriboulet/desktop so electron-builder publishes the GitHub Release to the fork. - linux.yml: trigger only on v* tags (+ workflow_dispatch); build only deb target (--linux deb) to avoid snapcraft dependency; remove branch triggers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Hey, I just noticed I made a pull request very similar to yours, but mine also builds rpm and appimage besides just snap and deb.
|
|
|
|
Sorry, I misread your issue. I thought you introduced a bug with your pull request and weren't able to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Ubuntu compatibility by building a
.debthat can be installed withsudo dpkg -i Raindrop.io_5.7.3_amd64.debValidated that the installation works, and login functionality works. Also added a build .yml that should work with release tags, but that can be changed to work with pushes to master since I think that's how the current ones in
masterwork right now.I leaned heavily on Copilot to drive these changes so I apologize if it's too much AI slop ahead of time. Any and all feedback is welcome.