Open
Conversation
Full 6-pass audit with triage. Fixes applied:
- A08-7 MEDIUM: Guard large positive exponents in toDecimalString
- A01-1/A01-2: CLAUDE.md docs for scripts and deployment
- A01-3: Replace require string with ScientificMinNotLessThanMax custom error
- A01-4/A01-5: Uncomment log10/pow10 deployed-parity tests
- A01-6/A01-7: Add format(Float,bool) and format(Float) deployed-parity tests
- A01-8: Add ScientificMinNotLessThanMax revert path test
- A01-10: Fix sub NatSpec ("a from b" -> "b from a")
- A01-11: Clarify div param NatSpec (dividend/divisor)
- A01-12: Fix pow10 NatSpec to say 10^a
- A02-4: Add CoefficientOverflow direct test
- A06-2: Add packLossy lossy-but-packable path test
- A06-6: Fix NatSpec reference to non-existent fromFixedDecimalLossyMem
- A06-7: Fix packLossy NatSpec (PackedFloat -> Float, add @return lossless)
- A06-11: Fix NatSpec references to non-existent divide/power10
- A06-12: Add missing @return NatSpec tags across LibDecimalFloat.sol
- A06-16: Replace dead (lossless); expression with (Float result,) destructuring
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- A06-20: Document why pow uses implementation internals directly - A07-01: Remove 7 unused imports in LibDecimalFloatDeploy.sol - A08-1/p3: Add @param scientific to toDecimalString NatSpec - A08-5/p4: Fix redundant import path in LibFormatDecimalFloat.sol - A08-6: Remove dead countSigFigs function and its test file - A09-1/p1: Add tests for exponent overflow in unabsUnsignedMulOrDivLossy - A09-1/p3, A09-5, A09-9: Add NatSpec to div, inv, compareRescale - A09-11: Add internals test file for 6 untested internal functions - A09-12: Add ExponentOverflow test for minus - A09-13: Add Log10Zero and Log10Negative revert tests - A09-14: Add MulDivOverflow revert test - A09-16/p4, A09-17/p4: Replace magic numbers 100/2000 with named constants - A10-1/p1: Add overflow check on exponent += eValue in parseDecimalFloatInline - A10-1/p4: Consolidate split imports in LibParseDecimalFloat.sol - A10-3: Document 67-digit limit and overflow check semantics - A10-7: Add ParseDecimalFloatExcessCharacters test for wrapper - A10-8: Add ParseDecimalPrecisionLoss and ExponentOverflow tests for wrapper - Update deploy constants for changed bytecode Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add NatSpec to DEPLOYMENT_SUITE_TABLES and DEPLOYMENT_SUITE_CONTRACT explaining expected env var values and default behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (52)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
Checks
By submitting this for review, I'm confirming I've done the following: