Changed library to use background loop instead of manually looping#27
Draft
juha-ylikoski wants to merge 2 commits intorandomsync:masterfrom
Draft
Changed library to use background loop instead of manually looping#27juha-ylikoski wants to merge 2 commits intorandomsync:masterfrom
juha-ylikoski wants to merge 2 commits intorandomsync:masterfrom
Conversation
Author
|
@randomsync what is your opinion on these test cases failing due to them being synchronous when they maybe should not be. I could make them asynchronous but I'm not sure how we could test synchronous receiving (in my opinion it is too time sensitive and prone to failures). Github is not letting me to include log.html but travis should have one shortly with the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #25
This pull requests tries to fix problems with mqtt broker suddenly disconnecting. #4 thinks it might be related to looping mechanism somehow not working properly with robot.
Changes
self._mqttc.loop_start()andself._mqttc.loop_stop()TODO
Some pub/sub test cases are still failing. This is caused by them being synchronous.
Example:
Test case
Publish a message with QOS 1 and validate that the message is receivedfirst sends a message to broker and reconnects, subscribes and tries to receive it. Due to this case using synchronousSubscribe And Validatemessage which was sent before has already timed out and cannot be received.