Skip to content

Remove unused variable n_rows#1704

Closed
maxwbuckley wants to merge 6 commits intorapidsai:mainfrom
maxwbuckley:patch-5
Closed

Remove unused variable n_rows#1704
maxwbuckley wants to merge 6 commits intorapidsai:mainfrom
maxwbuckley:patch-5

Conversation

@maxwbuckley
Copy link
Copy Markdown
Contributor

Removed unused variable n_rows in ivf_flat_serialize.cuh.

Removed unused variable n_rows in ivf_flat_serialize.cuh.
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Jan 14, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cjnolet cjnolet added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 14, 2026
@cjnolet cjnolet moved this from Todo to In Progress in Unstructured Data Processing Jan 14, 2026
@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Jan 14, 2026

/ok to test 2dc7241

@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Jan 14, 2026

/ok to test 90b2939

@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Jan 30, 2026

/ok to test 68f738a

@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Jan 30, 2026

/merge

@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Feb 7, 2026

/ok to test 13ec256

@aamijar
Copy link
Copy Markdown
Member

aamijar commented Feb 11, 2026

/ok to test 43871a2

@aamijar
Copy link
Copy Markdown
Member

aamijar commented Feb 12, 2026

Hi @maxwbuckley thanks for the PR. The reason CI is failing is because we need to keep the first raft::deserialize_scalar. We have to deserialize the entire input stream in order to properly assign to the correct variable types, hence we can't skip any of them.

@github-project-automation github-project-automation Bot moved this from In Progress to Done in Unstructured Data Processing Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants