fmemopen.c: portability fix around funopen()#368
Merged
timg236 merged 1 commit intoraspberrypi:masterfrom Apr 1, 2026
Merged
Conversation
As noted in main.c, funopen() is used when fmemopen() is not available. Unfortunately, funopen() is not portable and its definition is not stable across Operating Systems (Darwin/macOS uses fpos_t while NetBSD uses off_t). This change fixes the build on NetBSD, where fpos_t is an opaque type and does not support arithmetic. To be fair, even macOS' manual page for funopen() mentions it erroneously assumes that fpos_t is an integral type, and invites to read fseek(3) for a discussion of this issue. Therefore, arguably the default should be off_t instead, but I did not want to possibly break functionality anywhere else.
timg236
approved these changes
Mar 31, 2026
Collaborator
timg236
left a comment
timg236
left a comment
There was a problem hiding this comment.
I think this is ok, but NETBSD should be regarded as community maintained i.e. nobody at PiTowers is likely to build for this platform.
Contributor
Author
That's perfectly fine; thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in main.c, funopen() is used when fmemopen() is not available. Unfortunately, funopen() is not portable and its definition is not stable across Operating Systems (Darwin/macOS uses fpos_t while NetBSD uses off_t).
This change fixes the build on NetBSD, where fpos_t is an opaque type and does not support arithmetic. To be fair, even macOS' manual page for funopen() mentions it erroneously assumes that fpos_t is an integral type, and invites to read fseek(3) for a discussion of this issue. Therefore, arguably the default should be off_t instead, but I did not want to possibly break functionality anywhere else.