-
Notifications
You must be signed in to change notification settings - Fork 13
feat: migrate sidebar to Base UI #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughA refactoring of the SidebarRoot component that transitions from using Collapsible.Root composition to direct aside element rendering with explicit open/closed state management via data-open and data-closed attributes. Includes corresponding updates to CSS selectors, test expectations, and JSDoc annotations. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Description
Breaking Changes
data-state="expanded"→data-open,data-state="collapsed"→data-closeddata-collapse-disabledinstead ofdata-collapse-disabled="true")Changes
@radix-ui/react-collapsibledependency - component now uses plainuseStatefor state managementCollapsible.Rootprops, now extendsComponentPropsWithoutRef<'aside'>defaultOpen = truedefault valueuseStateinstead of Collapsible wrapperDocs & Tests
[data-open],[data-closed],[data-collapse-disabled])data-closedattribute instead ofdata-state="collapsed"onOpenChangecallback signature remains(open: boolean) => voidSummary by CodeRabbit
true.data-statetodata-open/data-closed.