Skip to content

feat: migrate to stable Base UI Drawer#722

Merged
rohanchkrabrty merged 3 commits intomainfrom
migrate-to-drawer
Mar 30, 2026
Merged

feat: migrate to stable Base UI Drawer#722
rohanchkrabrty merged 3 commits intomainfrom
migrate-to-drawer

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

  • Upgrade @base-ui/react from ^1.2.0 to ^1.3.0 to use the graduated stable Drawer component
  • Replace all DrawerPreview imports with Drawer from @base-ui/react/drawer across source files
  • Fix asChildrender prop usage on Drawer.Trigger in playground examples, doc demos, and tests (Base UI uses render, not Radix's asChild)
  • Update lockfile for the new dependency version

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
apsara Ready Ready Preview, Comment Mar 30, 2026 5:32am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

📝 Walkthrough

Walkthrough

The PR switches the drawer primitive import from DrawerPreview to Drawer across the drawer package, and updates the @base-ui/react dependency from ^1.2.0 to ^1.3.0. It also refactors usages of Drawer.Trigger to supply the trigger via a render prop (e.g., render={<Button />}) instead of wrapping a <Button> with asChild. Changes touch component implementations, demos, and tests; exported types and public interfaces remain unchanged.

Suggested reviewers

  • rohilsurana
  • rsbh
  • paanSinghCoder
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description is clearly related to the changeset, providing specific details about the dependency upgrade, import replacements, and API changes required for the migration.
Title check ✅ Passed The title directly reflects the main change: migrating the Drawer component from DrawerPreview to the stable Base UI Drawer following a dependency upgrade.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty changed the title feat: migrate Drawer from DrawerPreview to stable Base UI Drawer feat: migrate to stable Base UI Drawer Mar 30, 2026
@rohanchkrabrty rohanchkrabrty merged commit f3ab9c8 into main Mar 30, 2026
5 checks passed
@rohanchkrabrty rohanchkrabrty deleted the migrate-to-drawer branch March 30, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants