You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR switches the drawer primitive import from DrawerPreview to Drawer across the drawer package, and updates the @base-ui/react dependency from ^1.2.0 to ^1.3.0. It also refactors usages of Drawer.Trigger to supply the trigger via a render prop (e.g., render={<Button />}) instead of wrapping a <Button> with asChild. Changes touch component implementations, demos, and tests; exported types and public interfaces remain unchanged.
Suggested reviewers
rohilsurana
rsbh
paanSinghCoder
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name
Status
Explanation
Resolution
Docstring Coverage
⚠️ Warning
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.
Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name
Status
Explanation
Description check
✅ Passed
The description is clearly related to the changeset, providing specific details about the dependency upgrade, import replacements, and API changes required for the migration.
Title check
✅ Passed
The title directly reflects the main change: migrating the Drawer component from DrawerPreview to the stable Base UI Drawer following a dependency upgrade.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@base-ui/reactfrom^1.2.0to^1.3.0to use the graduated stableDrawercomponentDrawerPreviewimports withDrawerfrom@base-ui/react/draweracross source filesasChild→renderprop usage onDrawer.Triggerin playground examples, doc demos, and tests (Base UI usesrender, not Radix'sasChild)