Skip to content

fix: add .js extension to dayjs plugin imports for ESM compatibility#724

Merged
rohanchkrabrty merged 1 commit intomainfrom
fix-esm-support
Mar 30, 2026
Merged

fix: add .js extension to dayjs plugin imports for ESM compatibility#724
rohanchkrabrty merged 1 commit intomainfrom
fix-esm-support

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

  • Add .js extension to dayjs/plugin/customParseFormat import in date-picker.tsx
  • Add .js extension to dayjs/plugin/isSameOrAfter and dayjs/plugin/isSameOrBefore imports in filter-operations.tsx
  • Fixes ESM resolution failures when consuming @raystack/apsara in SSR/Node.js environments where bare subpath imports without extensions fail to resolve

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
apsara Ready Ready Preview, Comment Mar 30, 2026 7:41am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0bc50163-9562-45c1-b49b-406fd488838f

📥 Commits

Reviewing files that changed from the base of the PR and between 337dadd and b0cb881.

📒 Files selected for processing (2)
  • packages/raystack/components/calendar/date-picker.tsx
  • packages/raystack/components/data-table/utils/filter-operations.tsx

📝 Walkthrough

Walkthrough

The pull request updates Day.js plugin imports across two component files to use explicit .js module specifiers. The changes replace bare plugin paths with their corresponding .js extensions: customParseFormat becomes customParseFormat.js in the date-picker component, and isSameOrAfter and isSameOrBefore become isSameOrAfter.js and isSameOrBefore.js in the filter-operations utility. No logic, control flow, or runtime behavior is modified.

Suggested reviewers

  • rsbh
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: adding .js extensions to dayjs plugin imports for ESM compatibility.
Description check ✅ Passed The description is directly related to the changeset, detailing the specific files modified and the reason for the changes (ESM resolution failures in SSR/Node.js environments).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty merged commit 5abfc1c into main Mar 30, 2026
5 checks passed
@rohanchkrabrty rohanchkrabrty deleted the fix-esm-support branch March 30, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants