Skip to content

fix: update styles and migrate tooltip usage to compound pattern #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohanchkrabrty merged 2 commits into from
Mar 30, 2026
Merged

fix: update styles and migrate tooltip usage to compound pattern #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b955f8a
fix: styles and improper tooltip usage
rohanchkrabrty Mar 30, 2026
cbe12b2
fix: update tooltip usages to compound component pattern
rohanchkrabrty Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 20 additions & 17 deletions packages/raystack/components/calendar/calendar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,23 +149,26 @@ export const Calendar = function ({
const hasDateInfo = Boolean(dateComponent);

return (
<Tooltip
side='top'
disabled={loadingData || !showTooltip || !message}
message={message}
>
<button
{...buttonProps}
className={cx(
buttonProps.className,
hasDateInfo && styles.dayButtonWithInfo
)}
>
{hasDateInfo && (
<div className={styles.dayInfo}>{dateComponent}</div>
)}
<span className={styles.dayNumber}>{buttonProps.children}</span>
</button>
<Tooltip disabled={loadingData || !showTooltip || !message}>
<Tooltip.Trigger
render={
<button
{...buttonProps}
className={cx(
buttonProps.className,
hasDateInfo && styles.dayButtonWithInfo
)}
>
{hasDateInfo && (
<div className={styles.dayInfo}>{dateComponent}</div>
)}
<span className={styles.dayNumber}>
{buttonProps.children}
</span>
</button>
}
/>
<Tooltip.Content side='top'>{message}</Tooltip.Content>
</Tooltip>
);
},
Expand Down
4 changes: 2 additions & 2 deletions packages/raystack/components/input-field/input-field.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
width: 100%;
position: relative;
border-radius: var(--rs-radius-2);
border: 1px solid var(--rs-color-border-base-tertiary);
border: 0.5px solid var(--rs-color-border-base-tertiary);
background: var(--rs-color-background-base-primary);
transition: all 0.2s ease;
box-sizing: border-box;
Expand Down Expand Up @@ -310,4 +310,4 @@
.input-error-wrapper.variant-borderless:hover,
.input-error-wrapper.variant-borderless:focus-within {
border-color: transparent;
}
}
3 changes: 1 addition & 2 deletions packages/raystack/components/select/select.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,10 @@
user-select: none;
-webkit-user-select: none;
transition: all 0.2s ease;
box-shadow: var(--rs-shadow-feather);
}

.trigger-outline {
border: 0.5px solid var(--rs-color-border-base-secondary);
border: 0.5px solid var(--rs-color-border-base-tertiary);
}

.trigger-text {
Expand Down
2 changes: 1 addition & 1 deletion packages/raystack/components/text-area/text-area.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
width: 100%;
min-height: 64px;
background-color: var(--rs-color-background-base-primary);
border: 1px solid var(--rs-color-border-base-tertiary);
border: 0.5px solid var(--rs-color-border-base-tertiary);
border-radius: var(--rs-radius-2);
font-size: var(--rs-font-size-small);
line-height: var(--rs-line-height-small);
Expand Down
13 changes: 9 additions & 4 deletions packages/raystack/components/text-area/text-area.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,15 @@ function TextArea({
{!required && <span className={styles.optional}>(optional)</span>}
</label>
{infoTooltip && (
<Tooltip message={infoTooltip} side='right'>
<span className={styles.helpIcon}>
<InfoCircledIcon />
</span>
<Tooltip>
<Tooltip.Trigger
render={
<span className={styles.helpIcon}>
<InfoCircledIcon />
</span>
}
/>
<Tooltip.Content side='right'>{infoTooltip}</Tooltip.Content>
</Tooltip>
)}
</div>
Expand Down
7 changes: 6 additions & 1 deletion packages/raystack/figma/tooltip.figma.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,10 @@ figma.connect(Tooltip, '<FIGMA_LINK>?node-id=3598-25261', {
props: {
message: figma.textContent('Tooltip text')
},
example: props => <Tooltip {...props}>TOOLTIP_TRIGGER</Tooltip>
example: props => (
<Tooltip>
<Tooltip.Trigger render={<button />}>TOOLTIP_TRIGGER</Tooltip.Trigger>
<Tooltip.Content>{props.message}</Tooltip.Content>
</Tooltip>
)
});
Loading