RDKB-64035: MLO LM_Lite notifications enhancement#1033
Draft
stanislavkuchar2 wants to merge 1 commit intordkcentral:developfrom
Draft
RDKB-64035: MLO LM_Lite notifications enhancement#1033stanislavkuchar2 wants to merge 1 commit intordkcentral:developfrom
stanislavkuchar2 wants to merge 1 commit intordkcentral:developfrom
Conversation
stanislavkuchar2
force-pushed
the
RDKB-64035
branch
4 times, most recently
from
cbe74c4 to
f2386b3
Compare
stanislavkuchar2
force-pushed
the
RDKB-64035
branch
from
f2386b3 to
aa7e42c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances LM_Lite host notifications to better support MLO (Multi-Link Operation) by emitting link-aware DM reference lists (AP/SSID/RSSI) and adjusting when the LM_Lite notification is sent for MLO clients.
Changes:
- Updates LM_Lite notification string format to support bracketed,
;-delimited link lists for MLO. - Adds logic to build SSID/RSSI/AssociatedDevice DM reference lists across MLO links and refactors notification construction.
- Moves LM_Lite notification emission to occur after MLO link entries are added to per-VAP associated-device maps.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
source/utils/wifi_util.h |
Introduces a compile-time macro that forces the MLO LM_Lite format path. |
source/core/wifi_ctrl_rbus_handlers.c |
Updates LM_Lite message formatting for MLO and adds debug/test code in the notification path. |
source/core/wifi_ctrl_queue_handlers.c |
Adds helper functions to build DM reference lists for MLO and changes when LM_Lite notifications are emitted for association events. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+177
to
+178
| //Stano | ||
| #define CONFIG_MLO_ENABLED_NOTIFY_LM_LITE |
Comment on lines
+485
to
+487
| //Stano | ||
| {FILE *out = fopen("/tmp/log12.txt", "a"); | ||
| fprintf(out, " notify_LM_Lite_host: sync:%d - %s\n", sync, str); fflush(out);fclose(out);} |
| fprintf(out, " notify_LM_Lite_host: sync:%d - %s\n", sync, str); fflush(out);fclose(out);} | ||
|
|
||
| rc = get_bus_descriptor()->bus_set_string_fn(&ctrl->handle, WIFI_LMLITE_NOTIFY, str); | ||
| rc = RETURN_OK; //Stano. Test |
Comment on lines
+1811
to
+1824
| void update_lm_wifi_sync_host_AssociatedDevice_DM_refs(unsigned int vap_index, LM_wifi_host_t *host, assoc_dev_data_t *assoc_data) | ||
| { | ||
| char str[LM_GEN_STR_SIZE] = {0}; | ||
| unsigned int itrj = 0; | ||
|
|
||
| #ifdef CONFIG_MLO_ENABLED_NOTIFY_LM_LITE | ||
| if (assoc_data->dev_stats.cli_MLDEnable) { | ||
| for (int link_idx = 0; link_idx < MAX_NUM_RADIOS; link_idx++) { | ||
| if (assoc_data->mld_info.cli_LinkInfo[link_idx].cli_Valid) { | ||
| UINT link_vap_index = assoc_data->mld_info.cli_LinkInfo[link_idx].cli_VapIndex; | ||
| char assoc_device_str[LM_GEN_STR_SIZE] = { 0 }; | ||
| snprintf(assoc_device_str, sizeof(assoc_device_str), "Device.WiFi.AccessPoint.%d.AssociatedDevice.%d", link_vap_index+1, itrj+1); | ||
| if (strlen(str) + strlen(assoc_device_str) + 2 < sizeof(str)) { /*+1 for ';' +1 for '\0'*/ | ||
| if (strlen(str) > 0) { |
| { | ||
| get_AssociatedDevice_DM_ref(assoc_data->ap_index, assoc_data, assoc_device_str, sizeof(assoc_device_str)); | ||
| } | ||
| strncpy((char *)host->AssociatedDevice, assoc_device_str, sizeof(host->AssociatedDevice)); |
stanislavkuchar2
force-pushed
the
RDKB-64035
branch
from
aa7e42c to
2656b6a
Compare
stanislavkuchar2
force-pushed
the
RDKB-64035
branch
from
2656b6a to
c50342c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.