Skip to content

RDKCOM-5492: RDKBDEV-3336 De-authenticating Hotspot Clients Upon DHCP Failure#818

Merged
narendradandu merged 25 commits intordkcentral:developfrom
rhegde114:develop
Apr 10, 2026
Merged

RDKCOM-5492: RDKBDEV-3336 De-authenticating Hotspot Clients Upon DHCP Failure#818
narendradandu merged 25 commits intordkcentral:developfrom
rhegde114:develop

Conversation

@rhegde114
Copy link
Copy Markdown
Contributor

@rhegde114 rhegde114 commented Jan 6, 2026

Develop an event subscription handler in OneWifi to process the event received from hotspot component upon DHCP failure and initiated de-authentication of associated client

Dependent on rdkcentral/hotspot#32

rhegde114 and others added 5 commits December 4, 2025 13:40
             due to DHCP failure
Changes: 1. Added Rbus event handler to moniter event from hotspot
         component in case of DHCP failure
         2. push the event to queue to kick associated client when
         event is received
             due to DHCP failure
Changes: 1. Added Rbus event handler to moniter event from hotspot
         component in case of DHCP failure
         2. push the event to queue to kick associated client when
         event is received
@rhegde114 rhegde114 requested a review from a team as a code owner January 6, 2026 18:49
@pradeeptakdas pradeeptakdas changed the title RDKBDEV-3336:De-authenticating Hotspot Clients Upon DHCP Failure RDKCOM-5492: RDKBDEV-3336 De-authenticating Hotspot Clients Upon DHCP Failure Jan 7, 2026
@pradeeptakdas
Copy link
Copy Markdown
Contributor

Hi @rhegde114
Looks like the branch is out of date, Can you please rebase ?

@rhegde114
Copy link
Copy Markdown
Contributor Author

@pradeeptakdas , I have re-synced the branch.

Comment thread source/core/wifi_ctrl.h Outdated
Comment thread source/core/wifi_ctrl_rbus_handlers.c Outdated
Comment thread source/core/wifi_ctrl_rbus_handlers.c Outdated
Copy link
Copy Markdown
Contributor

@mateuszCieslak-GL mateuszCieslak-GL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update

Comment thread source/core/wifi_ctrl_rbus_handlers.c Outdated
Comment thread source/core/wifi_ctrl_rbus_handlers.c Outdated
Comment thread source/core/wifi_ctrl_rbus_handlers.c Outdated
Comment thread source/core/wifi_ctrl_rbus_handlers.c
Comment thread source/core/wifi_ctrl_rbus_handlers.c Outdated
             due to DHCP failure
Changes: 1. Added Rbus event handler to moniter event from hotspot
         component in case of DHCP failure
         2. push the event to queue to kick associated client when
         event is received
             due to DHCP failure
Changes: 1. Added Rbus event handler to moniter event from hotspot
         component in case of DHCP failure
         2. push the event to queue to kick associated client when
         event is received
             due to DHCP failure
Changes: 1. Added Rbus event handler to moniter event from hotspot
         component in case of DHCP failure
         2. push the event to queue to kick associated client when
         event is received
Copy link
Copy Markdown
Contributor

@mateuszCieslak-GL mateuszCieslak-GL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look ok to me.

             due to DHCP failure
Changes: 1. Added Rbus event handler to moniter event from hotspot
         component in case of DHCP failure
         2. push the event to queue to kick associated client when
         event is received
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an RBUS event subscription in OneWifi to handle hotspot DHCP-failure notifications and trigger de-authentication (kick) of the associated client.

Changes:

  • Introduces a new RBUS event handler to parse <mac>_<vap_index> and enqueue a kick-assoc-devices command.
  • Subscribes to the new hotspot RBUS event during bus_subscribe_events().
  • Adds a new subscription-state flag to wifi_ctrl_t and a new event-name macro.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
source/core/wifi_ctrl_rbus_handlers.c Adds DHCP-failure event handler and subscribes to the new RBUS event.
source/core/wifi_ctrl.h Adds a new *_subscribed flag to track the new event subscription.
include/wifi_base.h Defines the new hotspot RBUS event name constant.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/core/wifi_ctrl_rbus_handlers.c
Comment thread source/core/wifi_ctrl_rbus_handlers.c Outdated
Comment thread source/core/wifi_ctrl_rbus_handlers.c
Comment thread source/core/wifi_ctrl_rbus_handlers.c
Comment thread source/core/wifi_ctrl_rbus_handlers.c Outdated
Comment thread source/core/wifi_ctrl_rbus_handlers.c
rhegde114 and others added 9 commits March 27, 2026 10:52
             due to DHCP failure
Changes: 1. Added Rbus event handler to moniter event from hotspot
         component in case of DHCP failure
         2. push the event to queue to kick associated client when
         event is received
             due to DHCP failure
Changes: 1. Added Rbus event handler to moniter event from hotspot
         component in case of DHCP failure
         2. push the event to queue to kick associated client when
         event is received
@narendradandu narendradandu merged commit 95f1db3 into rdkcentral:develop Apr 10, 2026
7 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community contribution Contributions from community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants