RDKBWIFI-278: CLIENT ASSOC CTRL REQUEST#926
RDKBWIFI-278: CLIENT ASSOC CTRL REQUEST#926narendradandu merged 3 commits intordkcentral:developfrom
Conversation
b31e3de to
1c5dab9
Compare
8ab3213 to
b07a543
Compare
b07a543 to
eb55006
Compare
There was a problem hiding this comment.
Pull request overview
Implements EasyMesh “Client Assoc Ctrl Request” handling in the EM agent to block/unblock a station on a specific BSSID using the ACL mechanism, with optional expiry via a timer callback.
Changes:
- Adds a new EM bus namespace for
Device.WiFi.EM.ClientAssocCtrlRequest. - Introduces a new request payload type (
client_assoc_ctrl_req_t) for association control parameters. - Adds an EM event handler that updates ACL entries and schedules timed ACL removal.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 14 comments.
| File | Description |
|---|---|
| source/apps/em/wifi_em.h | Adds the new bus namespace string for the client association control request. |
| source/apps/em/wifi_em.c | Adds the ACL timer callback, event handler logic, and registers the new bus event in em_init(). |
| include/wifi_base.h | Adds the client_assoc_ctrl_req_t request structure used as the bytes payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f70d64d to
d2ca27c
Compare
d2ca27c to
b339695
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Internal builds verified by https://gerrit.teamccp.com/#/c/952530/ |
b339695 to
71cf376
Compare
52d2a31 to
97621ef
Compare
97621ef to
a4a305c
Compare
Implement client association control request handling on a per-station basis. The agent receives and processes the request, forwarding it from the agent to OneWiFi and then to rdk-wifi-hal to block or unblock clients using the ACL mechanism. Unit Testing: Triggered the association control request from the controller using rdkb-cli. Added a temporary handler in main.go and invoked it via a curl command. Note: EasyMesh(rdkb-cli) currently supports processing this command only for connected clients. Test Results: When the controller sends a request to block a connected client on a specific BSSID for a defined duration, the client is added to the ACL for that BSSID. If the client disconnects and attempts to reconnect, it is denied access to the same BSSID. When blocked on the 5GHz BSSID, the client was still able to connect to the 2.4GHz BSSID. After blocking the client on both 5GHz and 2.4GHz BSSIDs, the client was unable to connect until the validity timer expired. Signed-off-by: Sundram Patel <Sundram.p@tataelxsi.co.in>
a4a305c to
e354e4f
Compare
|
Internal build success - https://gerrit.teamccp.com/#/c/953895/ |
RDKBWIFI-278: CLIENT ASSOC CTRL REQUEST
Implement client association control request handling on a per-station basis.
The agent receives and processes the request, forwarding it from the agent to OneWiFi and then to rdk-wifi-hal to block or unblock clients using the ACL mechanism.
Unit Testing:
Triggered the association control request from the controller using rdkb-cli.
Added a temporary handler in main.go and invoked it via a curl command.
Note: EasyMesh(rdkb-cli) currently supports processing this command only for connected clients.
Test Results:
When the controller sends a request to block a connected client on a specific BSSID for a defined duration, the client is added to the ACL for that BSSID.
If the client disconnects and attempts to reconnect, it is denied access to the same BSSID.
When blocked on the 5GHz BSSID, the client was still able to connect to the 2.4GHz BSSID.
After blocking the client on both 5GHz and 2.4GHz BSSIDs, the client was unable to connect until the validity timer expired.
Signed-off-by: Sundram Patel Sundram.p@tataelxsi.co.in