Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an OVSM crash by updating the OVSDB translator to avoid processing STA security key material (PSK) when the STA VAP security mode is not a personal security mode.
Changes:
- Add an
is_personal_sec()guard intranslate_sta_vap_info_to_ovsdb_state_personal_sec()to early-return for non-personal security modes, avoiding invalid key handling/crash.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3158
to
+3159
| return webconfig_error_none; | ||
| } |
There was a problem hiding this comment.
The indentation in this new early-return block uses tabs/misaligned whitespace, which is inconsistent with the surrounding 4-space indentation in this file. Please re-indent these lines with spaces to match the existing style (and avoid mixed tab/space formatting issues in diffs and linters).
Suggested change
| return webconfig_error_none; | |
| } | |
| return webconfig_error_none; | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XB10-2357 Ovsm crash
Reason for change: Ovsm crashed due to improper handling of the security mode in the translator.
Test Procedure: No crash noticed after changes. Tested reboot, reset cases.
Risks: Low
Signed-off-by: Dharmalakshmi A Dharmalakshmi_Annamalai@comcast.com