Add PlayerTelemetry2: object-based T2 telemetry with PLAYER_TELEMETRY_SUPPORT guards#119
Draft
Add PlayerTelemetry2: object-based T2 telemetry with PLAYER_TELEMETRY_SUPPORT guards#119
Conversation
Co-authored-by: dp0000 <53818367+dp0000@users.noreply.github.com> Agent-Logs-Url: https://github.com/rdkcentral/middleware-player-interface/sessions/1d844f7f-da70-444e-83f2-06c123067bb1
Copilot
AI
changed the title
[WIP] Replace telemetry::send event with object creation
Add PlayerTelemetry2: object-based T2 telemetry event sending
Mar 26, 2026
Co-authored-by: dp0000 <53818367+dp0000@users.noreply.github.com> Agent-Logs-Url: https://github.com/rdkcentral/middleware-player-interface/sessions/443ab31e-2aa2-40a5-86b4-178f8632d9ea
Copilot
AI
changed the title
Add PlayerTelemetry2: object-based T2 telemetry event sending
Add PlayerTelemetry2: object-based T2 telemetry with PLAYER_TELEMETRY_SUPPORT guards
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a
PlayerTelemetry2module — replacing directtelemetry::sendfunction calls with an object-based API — and gates the entire feature behind#ifdef PLAYER_TELEMETRY_SUPPORT/CMAKE_PLAYER_TELEMETRY_SUPPORT, consistent with howSUBTITLE_SUPPORTEDandGST_SUBTEC_ENABLEDare handled in this codebase.New module:
playerTelemetry/PlayerTelemetryInitializer— manages T2init/uninitlifecycle as a process-scoped static (destructor handles cleanup)PlayerTelemetry2— object-based send API backed by RDK T2 (t2_event_s), guarded by#ifndef PLAYER_SIMULATOR_BUILDfor non-device buildsBuild integration
playerTelemetry/CMakeLists.txtbuildslibplayertelemetryand propagates-DPLAYER_TELEMETRY_SUPPORTviatarget_compile_definitions PUBLICCMakeLists.txt:include_dirs,add_subdirectory, andtarget_link_librariesforplayertelemetryare all insideif(CMAKE_PLAYER_TELEMETRY_SUPPORT)— opt-in, off by defaultpkgconfig/libplayertelemetry.pc.inadded for downstream consumersTests:
test/utests/tests/PlayerTelemetryTests/send()overloads (raw string, null, and typed-map variants)PLAYER_SIMULATOR_BUILDandPLAYER_TELEMETRY_SUPPORT; test bodies are wrapped in#ifdef PLAYER_TELEMETRY_SUPPORTso they compile cleanly with or without the feature enabled💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.