Add PLAYER_TELEMETRY_SUPPORT guards around std::map telemetry blocks in pipeline state changes#120
Draft
Add PLAYER_TELEMETRY_SUPPORT guards around std::map telemetry blocks in pipeline state changes#120
Conversation
- Create PlayerTelemetry.h with PlayerTelemetry2 class declaration - Create PlayerTelemetry.cpp with PlayerTelemetry2::send implementation - Add #ifdef PLAYER_TELEMETRY_SUPPORT guards with std::map declarations in SetStateWithWarnings for all pipeline state change cases (FAILURE, SUCCESS, ASYNC, UNKNOWN) - Update CMakeLists.txt to conditionally compile PlayerTelemetry.cpp and add PlayerTelemetry.h to headers/install list Co-authored-by: dp0000 <53818367+dp0000@users.noreply.github.com> Agent-Logs-Url: https://github.com/rdkcentral/middleware-player-interface/sessions/3d5f3dc4-bf47-4991-9822-0ba1e6d6e045
Copilot
AI
changed the title
[WIP] Add player telemetry support in pipeline state changes
Add PLAYER_TELEMETRY_SUPPORT guards around std::map telemetry blocks in pipeline state changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline state change handling in
SetStateWithWarningslacked telemetry instrumentation, and no mechanism existed to conditionally compile telemetry support.Changes
PlayerTelemetry.h— NewPlayerTelemetry2class withsend(marker, iMap, sMap, fMap)accepting typedstd::mappayloads for int, string, and float valuesPlayerTelemetry.cpp— Default implementation logging all telemetry entries viaMW_LOG_MILInterfacePlayerRDK.cpp— Telemetry blocks added under#ifdef PLAYER_TELEMETRY_SUPPORTin every case of theSetStateWithWarningsswitch, mapping current/pending/target state into typed maps before dispatch:Covered cases:
FAILURE,SUCCESS,ASYNC, anddefault(→MW_PIPELINE_STATE_CHANGE_UNKNOWN).CMakeLists.txt—CMAKE_PLAYER_TELEMETRY_SUPPORToption conditionally appendsPlayerTelemetry.cppand defines-DPLAYER_TELEMETRY_SUPPORT;PlayerTelemetry.hadded to headers and install target💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.