Guard telemetry events (MW_LOG_MIL) with #ifdef PLAYER_TELEMETRY_SUPPORT#121
Draft
Guard telemetry events (MW_LOG_MIL) with #ifdef PLAYER_TELEMETRY_SUPPORT#121
Conversation
Co-authored-by: dp0000 <53818367+dp0000@users.noreply.github.com> Agent-Logs-Url: https://github.com/rdkcentral/middleware-player-interface/sessions/93917651-a79d-4b85-9504-6df541630832
Copilot
AI
changed the title
[WIP] Update code to include PLAYER_TELEMETRY_SUPPORT for telemetry events
Guard telemetry events (MW_LOG_MIL) with #ifdef PLAYER_TELEMETRY_SUPPORT
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MW_LOG_MIL(Milestone log) is the telemetry event channel — it maps toETHAN_LOG_MILESTONE, the only level that passes through Ethan logger in production builds. AllMW_LOG_MILcall sites now compile out when telemetry support is disabled.Changes
playerLogManager/PlayerLogManager.h: WrapMW_LOG_MILmacro definition with#ifdef PLAYER_TELEMETRY_SUPPORT; falls back to a no-op when not defined:CMakeLists.txt: AddPLAYER_TELEMETRY_SUPPORTcmake option (defaultOFF) that injects-DPLAYER_TELEMETRY_SUPPORTinto compile definitions:Enable at configure time with
-DPLAYER_TELEMETRY_SUPPORT=ON. Guarding the macro definition rather than individual call sites means all existing and futureMW_LOG_MILusages are automatically covered.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.