Add PlayerTelemetry.cpp with Telemetry 2.0 integration and PLAYER_TELEMETRY_SUPPORT guards at all call sites#122
Draft
Copilot wants to merge 3 commits intocopilot/insert-runtime-telemetry-eventsfrom
Conversation
…TELEMETRY_SUPPORT guards at all call sites Agent-Logs-Url: https://github.com/rdkcentral/middleware-player-interface/sessions/14ef8a4a-739c-4644-9588-9e61e93269b6 Co-authored-by: dp0000 <53818367+dp0000@users.noreply.github.com>
…in InterfacePlayerRDK.cpp Agent-Logs-Url: https://github.com/rdkcentral/middleware-player-interface/sessions/14ef8a4a-739c-4644-9588-9e61e93269b6 Co-authored-by: dp0000 <53818367+dp0000@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add ifdef PLAYER_TELEMETRY_SUPPORT for telemetry events
Add PlayerTelemetry.cpp with Telemetry 2.0 integration and PLAYER_TELEMETRY_SUPPORT guards at all call sites
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Telemetry events were emitted via inline
MW_LOG_MILin the header with no call-site guards, coupling telemetry to the log subsystem and compiling all payload construction even in non-telemetry builds. This wires the implementation to the RDK Telemetry 2.0 framework (t2_event_s) and adds explicit#ifdef PLAYER_TELEMETRY_SUPPORTguards at every emission point.PlayerTelemetry.cpp(new)Implements
PlayerTelemetry::sendEvent()usingt2_event_s(), compiled only whenPLAYER_TELEMETRY_SUPPORTis defined:PlayerTelemetry.h#include "PlayerLogManager.h"from the active branch (no longer needed)PlayerTelemetry::sendEvent()from inline-defined to declared-only; the no-op#elsestubs are retained for backward compatibilityCall-site guards (5 files)
All
TelemetryPayloadconstruction andPlayerTelemetry::sendEvent()calls inInterfacePlayerRDK.cpp,GstHandlerControl.cpp,drm/DrmSessionManager.cpp,drm/ocdm/opencdmsessionadapter.cpp, andgst-plugins/drm/gst/gstcdmidecryptor.cppare wrapped:CMakeLists.txtWhen
CMAKE_PLAYER_TELEMETRY_SUPPORTis set: addsPlayerTelemetry.cppto sources, resolves thetelemetry2_marker.hinclude path, and links-ltelemetry2.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.