RDKEMW-11934 : Fix build failure in MAC#64
Conversation
To resolve MacOS compilation failure
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
Pull request overview
This PR addresses a build failure on macOS caused by TagLib version 2.1.1, which is used on macOS but lacks the TagLib::uint type alias that exists in newer versions. The fix introduces a compatibility header to provide this type alias.
Changes:
- Added a new compatibility header file
taglib_compat.hthat definesTagLib::uintas an alias forunsigned int - Modified the build script to force-include this compatibility header during gst-plugins-good compilation on macOS
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/taglib_compat.h | New compatibility header that defines the missing TagLib::uint type alias for TagLib 2.1.1 |
| scripts/install_gstreamer.sh | Updated to force-include the compatibility header via CXXFLAGS during macOS builds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cf3e10a to
03052c7
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 18 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
test/utests/tests/GstPlayer/CMakeLists.txt:111
- The libraries GMOCK_LINK_LIBRARIES and GTEST_LINK_LIBRARIES are being linked twice: once at lines 80-85 (for all platforms) and again at line 111 (specifically for APPLE). This creates redundant linking which can cause issues or warnings during the build process. Consider removing these duplicate link specifications from either the general linking section or the APPLE-specific section.
target_link_libraries(${EXEC_NAME} PRIVATE
PkgConfig::GST
${LIBCJSON_LINK_LIBRARIES}
${GMOCK_LINK_LIBRARIES}
${GTEST_LINK_LIBRARIES}
)
if (CMAKE_XCODE_BUILD_SYSTEM)
# XCode schema target
xcode_define_schema(${EXEC_NAME})
endif()
if (COVERAGE_ENABLED)
player_utest_add_cov(${EXEC_NAME})
endif()
link_directories(${GSTREAMER_LIBRARY_DIRS})
if(APPLE)
find_package(PkgConfig REQUIRED)
set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH ON)
set(CMAKE_INSTALL_RPATH "/usr/local/lib")
set(CMAKE_BUILD_RPATH "/usr/local/lib")
set(CMAKE_MACOSX_RPATH ON)
set(GSTREAMER_FRAMEWORK_DIR "/Library/Frameworks")
set(GSTREAMER_FRAMEWORK_LIB "${GSTREAMER_FRAMEWORK_DIR}/GStreamer.framework/Versions/1.0/lib")
set_target_properties(${EXEC_NAME} PROPERTIES
INSTALL_RPATH "${GSTREAMER_FRAMEWORK_LIB};${GSTREAMER_FRAMEWORK_DIR}"
BUILD_WITH_INSTALL_RPATH TRUE
)
target_link_options(${EXEC_NAME} PRIVATE -F${GSTREAMER_FRAMEWORK_DIR})
target_link_libraries(${EXEC_NAME} PRIVATE "-framework GStreamer")
target_link_libraries(${EXEC_NAME} PRIVATE fakes -lpthread ${OS_LD_FLAGS} ${GMOCK_LINK_LIBRARIES} ${GTEST_LINK_LIBRARIES})
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RDKEMW-11934 : Fix build failure in MAC
Reason for change: taglib version using in MacOS is 2.1.1 so build failure occurs in TagLib::uint
Test Procedure: Refer Ticket
Risks: Low
Priority: P2
Signed-off-by: Rekha Kandhavelan [rekha_kandhavelan@comcast.com]