Skip to content

RDKEMW-11934 : Fix build failure in MAC#64

Merged
balasaraswathy-n merged 47 commits intodevelopfrom
feature/RDKEMW-11934
Feb 2, 2026
Merged

RDKEMW-11934 : Fix build failure in MAC#64
balasaraswathy-n merged 47 commits intodevelopfrom
feature/RDKEMW-11934

Conversation

@rekhap2kandhavelan
Copy link
Copy Markdown
Contributor

RDKEMW-11934 : Fix build failure in MAC
Reason for change: taglib version using in MacOS is 2.1.1 so build failure occurs in TagLib::uint
Test Procedure: Refer Ticket
Risks: Low
Priority: P2
Signed-off-by: Rekha Kandhavelan [rekha_kandhavelan@comcast.com]

To resolve MacOS compilation failure
@rekhap2kandhavelan rekhap2kandhavelan requested a review from a team as a code owner January 8, 2026 10:59
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 8, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a build failure on macOS caused by TagLib version 2.1.1, which is used on macOS but lacks the TagLib::uint type alias that exists in newer versions. The fix introduces a compatibility header to provide this type alias.

Changes:

  • Added a new compatibility header file taglib_compat.h that defines TagLib::uint as an alias for unsigned int
  • Modified the build script to force-include this compatibility header during gst-plugins-good compilation on macOS

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
scripts/taglib_compat.h New compatibility header that defines the missing TagLib::uint type alias for TagLib 2.1.1
scripts/install_gstreamer.sh Updated to force-include the compatibility header via CXXFLAGS during macOS builds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 21, 2026 16:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 18 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 21, 2026 17:57
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

test/utests/tests/GstPlayer/CMakeLists.txt:111

  • The libraries GMOCK_LINK_LIBRARIES and GTEST_LINK_LIBRARIES are being linked twice: once at lines 80-85 (for all platforms) and again at line 111 (specifically for APPLE). This creates redundant linking which can cause issues or warnings during the build process. Consider removing these duplicate link specifications from either the general linking section or the APPLE-specific section.
target_link_libraries(${EXEC_NAME} PRIVATE
    PkgConfig::GST
    ${LIBCJSON_LINK_LIBRARIES}
    ${GMOCK_LINK_LIBRARIES}
    ${GTEST_LINK_LIBRARIES}
)

if (CMAKE_XCODE_BUILD_SYSTEM)
  # XCode schema target
  xcode_define_schema(${EXEC_NAME})
endif()

if (COVERAGE_ENABLED)
    player_utest_add_cov(${EXEC_NAME})
endif()

link_directories(${GSTREAMER_LIBRARY_DIRS})
if(APPLE)
  find_package(PkgConfig REQUIRED)
  set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH ON)
  set(CMAKE_INSTALL_RPATH "/usr/local/lib")
  set(CMAKE_BUILD_RPATH "/usr/local/lib")
  set(CMAKE_MACOSX_RPATH ON)
  set(GSTREAMER_FRAMEWORK_DIR "/Library/Frameworks")
  set(GSTREAMER_FRAMEWORK_LIB "${GSTREAMER_FRAMEWORK_DIR}/GStreamer.framework/Versions/1.0/lib")
  set_target_properties(${EXEC_NAME} PROPERTIES
    INSTALL_RPATH "${GSTREAMER_FRAMEWORK_LIB};${GSTREAMER_FRAMEWORK_DIR}"
    BUILD_WITH_INSTALL_RPATH TRUE
  )
  target_link_options(${EXEC_NAME} PRIVATE -F${GSTREAMER_FRAMEWORK_DIR})
  target_link_libraries(${EXEC_NAME} PRIVATE "-framework GStreamer")
  target_link_libraries(${EXEC_NAME} PRIVATE fakes -lpthread ${OS_LD_FLAGS} ${GMOCK_LINK_LIBRARIES} ${GTEST_LINK_LIBRARIES})

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 22, 2026 05:59
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 22, 2026 11:24
rekhap2kandhavelan and others added 2 commits January 22, 2026 16:56
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rekhap2kandhavelan and others added 2 commits January 22, 2026 21:58
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 23, 2026 09:47
rekhap2kandhavelan and others added 3 commits January 23, 2026 15:22
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 23, 2026 10:10
rekhap2kandhavelan and others added 6 commits January 23, 2026 15:45
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 23, 2026 10:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 28, 2026 06:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 10 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@balasaraswathy-n balasaraswathy-n merged commit ba056a8 into develop Feb 2, 2026
12 of 15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants