RDKEMW-11881 : player-interface component separation by narenr94 · Pull Request #65 · rdkcentral/middleware-player-interface

narenr94 · 2026-01-20T08:24:49Z

RDKEMW-11881 : player-interface component separation
Reason for change : remove middleware and platform related code from AAMP
Test Steps : mentioned in ticket
Signed-off by : R.Naren naren_ramesh@comcast.com

RDKEMW-9809 : Latest AAMP sync

To resolve MacOS compilation failure

Copilot

Pull request overview

This pull request separates player-interface components from AAMP by removing middleware and platform-related code. The changes primarily focus on adding audio routing functionality to vendor-specific SOC interfaces and reorganizing test infrastructure.

Changes:

Added SetAudioRoutingProperties method to SOC interface hierarchy for Realtek-specific audio configuration
Reorganized test infrastructure by removing TtmlSubtecParser and SubtecTests, adding comprehensive InterfacePlayer tests
Updated CMake build configurations across multiple test suites to standardize coverage setup and linking

Reviewed changes

Copilot reviewed 80 out of 92 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
vendor/realtek/RealtekSocInterface.h	Added SetAudioRoutingProperties method declaration
vendor/realtek/RealtekSocInterface.cpp	Implemented audio routing configuration for OMX decoders
vendor/SocInterface.h	Added virtual SetAudioRoutingProperties base method
vendor/default/DefaultSocInterface.cpp	Updated comment to remove OSX/Ubuntu reference
vendor/brcm/BrcmSocInterface.h	Whitespace formatting fix
vendor/amlogic/AmlogicSocInterface.h	Removed trailing empty line
vendor/amlogic/AmlogicSocInterface.cpp	Fixed trailing whitespace
test/utests/tests/TtmlSubtecParser/*	Removed entire test suite (1688 lines)
test/utests/tests/SubtecTests/*	Removed entire test suite (1952 lines)
test/utests/tests/InterfacePlayerTests/*	Added new comprehensive test suite (2535 lines)
test/utests/tests/*/CMakeLists.txt	Standardized coverage configuration and linking
test/utests/tests/GstPlayer/*.cpp	Updated ConfigurePipeline calls with new parameters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rdkcmf-jenkins · 2026-01-20T08:37:55Z

Coverity Issue - Resource leak in object

Allocating memory by calling "new Configs".

High Impact, CWE-401
CTOR_DTOR_LEAK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
InterfacePlayerRDK.cpp:76

rdkcmf-jenkins · 2026-01-20T08:37:55Z

mp4demux/mp4demux.hpp

-		verbose(verbose), sampleOffset(), sencPresent(false)
+	Mp4Demux( bool verbose=false ) : audio{}, video{}, stream_format(), data_reference_index(), codec_type(), codec_data(), is_encrypted(), iv_size(), crypt_byte_block(), skip_byte_block(), constant_iv_size(), constant_iv(), timescale(), samples(), default_kid(), got_auxiliary_information_offset(), auxiliary_information_offset(), scheme_type(), scheme_version(), original_media_type(), cenc_aux_info_sizes(), protectionEvents(), moof_ptr(), ptr(), indent(), version(), flags(), baseMediaDecodeTime(), fragment_duration(), track_id(), base_data_offset(), default_sample_description_index(), default_sample_duration(), default_sample_size(), default_sample_flags(), creation_time(), modification_time(), duration(), rate(), volume(), matrix{}, layer(), alternate_group(), width_fixed(), height_fixed(), language(), verbose(verbose)
 	{
 	}


Coverity Issue - Uninitialized scalar field

Non-static class member "sencPresent" is not initialized in this constructor nor in any functions that it calls.

Medium Impact, CWE-457
UNINIT_CTOR

…kage issue

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…central/middleware-player-interface into feature/RDKEMW-11934_TagAamp

Copilot

Pull request overview

Copilot reviewed 85 out of 96 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-29T07:29:15Z

subtec/subtecparser/TextStyleAttributes.h

+     * @patam[out] colorOut - color option for the input value
     * @return int - 0 for success, -1 for failure
     */
    int getColor(std::string input, SupportedColors *colorOut);

    /**
     * @fn getEdgeType
     * @param[in] input - input edge type value
-     * @param[out] edgeTypeOut - edge type option for the input value
+     * @patam[out] edgeTypeOut - edge type option for the input value
     * @return int - 0 for success, -1 for failure
     */
    int getEdgeType(std::string input, EdgeType *edgeTypeOut);

    /**
     * @fn getOpacity
     * @param[in] input - input opacity value
-     * @param[out] edgeTypeOut - opacity option for the input value
+     * @patam[out] edgeTypeOut - opacity option for the input value


The Doxygen comments for getColor, getEdgeType, and getOpacity use @patam[out] instead of @param[out] for the output parameters, which will break parameter documentation generation. Please correct these tags to use @param[out] so the documentation associates the comments with the actual parameters.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

auto generate pc files using cmake

RDKEMW-11934 : Build Failing for middleware-player-interface branch on macOS

github-actions · 2026-02-04T10:23:40Z

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ (narenr94)[https://github.com/narenr94]
❌ @rekhap2kandhavelan
_{You can retrigger this bot by commenting recheck in this Pull Request.}_{Posted by the CLA Assistant Lite bot.}

Copilot

Pull request overview

Copilot reviewed 103 out of 114 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-04T10:34:41Z

test/utests/tests/PluginsTests/CMakeLists.txt

@@ -84,8 +80,9 @@ set(PLAYER_SOURCES
 add_executable(${EXEC_NAME}
 			   ${TEST_SOURCES}
 			   ${MOCK_SOURCES}
+			   ${FAKE_SOURCES}
 			   ${PLAYER_SOURCES})


FAKE_SOURCE is defined at the top of this file, but FAKE_SOURCES is used in the add_executable call, so FakeDRMSessionManager.cpp will not actually be compiled into the test target. This likely breaks the intention of using the fake DRM session manager in these tests and may lead to unresolved symbols or unintended linkage against the real implementation. Update the variable name consistently (e.g., rename FAKE_SOURCE to FAKE_SOURCES or use FAKE_SOURCE in add_executable).

Copilot · 2026-02-04T10:34:41Z

mp4demux/mp4demux.hpp

@@ -888,21 +864,7 @@ class Mp4Demux

 				case MultiChar_Constant("moof"):  // Movie Fragment
 					moof_ptr = ptr-8;


sampleOffset is now used in process_auxiliary_information, parseSampleAuxiliaryInformationSizes, and parseSampleEncryptionBox, but it is no longer initialized or updated when a new moof box is parsed. Previously, sampleOffset and related encryption state were reset in the moof case; with that logic removed, sampleOffset will contain an indeterminate or stale value, which can cause out-of-bounds access or incorrect IV/subsample association when handling CENC auxiliary information. To fix this, reintroduce initialization of sampleOffset (e.g., sampleOffset = samples.size();) and any necessary state resets when encountering a new moof box.

Suggested change

moof_ptr = ptr-8;

moof_ptr = ptr-8;

sampleOffset = samples.size();

balasaraswathy-n and others added 9 commits December 13, 2025 14:22

Merge pull request #49 from rdkcentral/feature/RDKEMW-9809

b4f9bd9

RDKEMW-9809 : Latest AAMP sync

2.11.0 sync

13a00f1

vendor fix

d6192cf

vendor fix 02

d230abe

sync

773a18e

run.sh update

beeb932

remove gstreamer-video-1.0

32dac80

revert remove gstreamer-video-1.0

69f23c9

Add taglib compatibility header

8f0792a

To resolve MacOS compilation failure

narenr94 requested a review from a team as a code owner January 20, 2026 08:24

Copilot AI review requested due to automatic review settings January 20, 2026 08:24

Copilot started reviewing on behalf of narenr94 January 20, 2026 08:25 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

rdkcmf-jenkins reviewed Jan 20, 2026

View reviewed changes

rekhap2kandhavelan and others added 15 commits January 21, 2026 16:21

Add include path for taglib compatibility header and resolve sssl pac…

03052c7

…kage issue

Update FakeGStreamer.cpp

19b30cd

Update scripts/install_gstreamer.sh

8b48ce8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test/utests/tests/GstPlayer/CMakeLists.txt

71b8104

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test/utests/fakes/FakeGStreamer.cpp

d2589b1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update scripts/taglib_compat.h

d1e5351

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test/utests/fakes/FakeGStreamer.cpp

226ed3f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test/utests/fakes/FakeGStreamer.cpp

42fd35f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test/utests/tests/GstPlayer/CMakeLists.txt

e8bd8c0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update scripts/taglib_compat.h

85ec78a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

resolve conflict

ca743e0

Update CMakeLists.txt

6328160

Update test/utests/tests/PluginsTests/CMakeLists.txt

99b156d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test/utests/fakes/FakeGStreamer.cpp

025076e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test/utests/fakes/FakeGStreamer.cpp

1a7bf29

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

rekhap2kandhavelan and others added 15 commits January 23, 2026 15:45

Update scripts/taglib_compat.h

0565c4c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test/utests/tests/PluginsTests/CMakeLists.txt

b613a33

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update scripts/install_subtec.sh

2832cdd

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test/utests/mocks/MockGStreamer.h

2e288b7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test/utests/fakes/FakeGstUtils.cpp

6d327d1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test/utests/fakes/FakeGStreamer.cpp

ba53f3e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update FakeGStreamer.cpp

fe65678

Update ClearKeyDrmSessionTests.cpp

9f61afd

Merge branch 'main' into feature/RDKEMW-11881

bab8db1

rebase with feature/RDKEMW-11881 branch

1c8bb91

rebase with feature/RDKEMW-11881 branch

f6487b3

Merge branch 'feature/RDKEMW-11934_TagAamp' of https://github.com/rdk…

e8e0448

…central/middleware-player-interface into feature/RDKEMW-11934_TagAamp

Update CMakeLists.txt

534d480

Update CMakeLists.txt

047319d

aamp 11881 sync

6cef0de

Copilot AI review requested due to automatic review settings January 29, 2026 07:22

Copilot started reviewing on behalf of narenr94 January 29, 2026 07:23 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

nrames759 and others added 6 commits January 29, 2026 14:08

auto generate pc files

c3310d2

pc files name fix

f96a7c3

pc files req fix

ac1c8ef

log to indicate lib externally built for player

f9e53b4

Merge pull request #70 from rdkcentral/feature/RDKEMW-11881_pc

dd75ba1

auto generate pc files using cmake

Merge pull request #69 from rdkcentral/feature/RDKEMW-11934_TagAamp

e46d94c

RDKEMW-11934 : Build Failing for middleware-player-interface branch on macOS

Copilot AI review requested due to automatic review settings February 4, 2026 10:23

Copilot started reviewing on behalf of narenr94 February 4, 2026 10:23 View session

Copilot AI reviewed Feb 4, 2026

View reviewed changes

copilot review 05

1a08be8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RDKEMW-11881 : player-interface component separation#65

RDKEMW-11881 : player-interface component separation#65
narenr94 wants to merge 68 commits intomainfrom
feature/RDKEMW-11881

narenr94 commented Jan 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

rdkcmf-jenkins commented Jan 20, 2026 •

edited

Loading

Uh oh!

rdkcmf-jenkins Jan 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Feb 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

		@@ -888,21 +864,7 @@ class Mp4Demux

		case MultiChar_Constant("moof"): // Movie Fragment
		moof_ptr = ptr-8;

	moof_ptr = ptr-8;
	moof_ptr = ptr-8;
	sampleOffset = samples.size();

Conversation

narenr94 commented Jan 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

rdkcmf-jenkins commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Resource leak in object

Issue location

Uh oh!

rdkcmf-jenkins Jan 20, 2026

Choose a reason for hiding this comment

Coverity Issue - Uninitialized scalar field

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rdkcmf-jenkins commented Jan 20, 2026 •

edited

Loading