-
Notifications
You must be signed in to change notification settings - Fork 3
RDKEMW-11877 : Metrics Collection for Player Interface Public APIs #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
d8f6b7c
c90d369
e3e2442
13a00f1
d6192cf
d230abe
18c73ec
773a18e
beeb932
32dac80
69f23c9
11e2321
c564720
d257d45
650f5bf
8f0792a
e579971
03052c7
19b30cd
8b48ce8
71b8104
d2589b1
d1e5351
226ed3f
42fd35f
e8bd8c0
85ec78a
ca743e0
6328160
99b156d
025076e
1a7bf29
c6de14e
225061f
6a4b3b1
d2d123b
cc7ce25
3942ded
6045701
abe935b
6c7d6ad
95b6cc7
e044d63
a606813
a0d1955
f5926b2
a356d1c
3d04d8c
a14be93
8133c5f
a248a60
344ec4a
004c310
119dcf0
0565c4c
b613a33
2832cdd
2e288b7
6d327d1
ba53f3e
fe65678
9f61afd
bab8db1
1c8bb91
f6487b3
e8e0448
534d480
047319d
6cef0de
c3310d2
2618f4d
7161fc8
f96a7c3
ac1c8ef
f9e53b4
dd75ba1
e46d94c
d9627b3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -17,7 +17,12 @@ | |||||||
| # limitations under the License. | ||||||||
|
|
||||||||
| cmake_minimum_required(VERSION 3.5) | ||||||||
| project(Playergstinterface) | ||||||||
| project(Playergstinterface VERSION 0.1.0) | ||||||||
|
|
||||||||
| # Set default install prefix | ||||||||
| if(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT) | ||||||||
| set(CMAKE_INSTALL_PREFIX "/usr" CACHE PATH "Default install prefix" FORCE) | ||||||||
| endif() | ||||||||
| set(CMAKE_CXX_STANDARD 17) | ||||||||
| find_package(OpenSSL REQUIRED) | ||||||||
| option(DISABLE_SECURITY_TOKEN "Disable security token" OFF) | ||||||||
|
|
@@ -26,6 +31,12 @@ if(DISABLE_SECURITY_TOKEN) | |||||||
| add_definitions(-DDISABLE_SECURITY_TOKEN) | ||||||||
| endif() | ||||||||
|
|
||||||||
| option(ENABLE_MW_PROFILING "Enable middleware profiling" ON) | ||||||||
|
|
||||||||
| if(ENABLE_MW_PROFILING) | ||||||||
| add_definitions(-DENABLE_MW_PROFILING) | ||||||||
| endif() | ||||||||
|
|
||||||||
| # Option for building pi-cli | ||||||||
| option(BUILD_PICLI "Build the pi-cli test project" OFF) | ||||||||
|
|
||||||||
|
|
@@ -160,7 +171,11 @@ set(LIBPLAYERGSTINTERFACE_HEADERS | |||||||
| vendor/default/DefaultSocInterface.h | ||||||||
| subtitle/vttCue.h | ||||||||
| ProcessHandler.h | ||||||||
| PerfProfiler.h | ||||||||
| ) | ||||||||
| if(ENABLE_MW_PROFILING) | ||||||||
| list(APPEND LIBPLAYERGSTINTERFACE_HEADERS PerfProfiler.h) | ||||||||
| endif() | ||||||||
|
|
||||||||
| install(FILES closedcaptions/CCTrackInfo.h | ||||||||
| PlayerScheduler.h | ||||||||
|
|
@@ -197,7 +212,11 @@ install(FILES closedcaptions/CCTrackInfo.h | |||||||
| subtec/libsubtec/SubtecPacket.hpp | ||||||||
| playerisobmff/playerisobmffbuffer.h | ||||||||
| playerisobmff/playerisobmffbox.h | ||||||||
| PerfProfiler.h | ||||||||
| DESTINATION include) | ||||||||
| if(ENABLE_MW_PROFILING) | ||||||||
| install(FILES PerfProfiler.h DESTINATION include) | ||||||||
| endif() | ||||||||
|
Comment on lines
+215
to
+219
|
||||||||
|
|
||||||||
| set(SOURCES | ||||||||
| InterfacePlayerRDK.cpp | ||||||||
|
|
@@ -211,7 +230,11 @@ set(SOURCES | |||||||
| vendor/default/DefaultSocInterface.cpp | ||||||||
| drm/processProtectionHls.cpp | ||||||||
| ProcessHandler.cpp | ||||||||
| PerfProfiler.cpp | ||||||||
| ) | ||||||||
| if(ENABLE_MW_PROFILING) | ||||||||
| list(APPEND SOURCES PerfProfiler.cpp) | ||||||||
| endif() | ||||||||
|
Comment on lines
+235
to
+237
|
||||||||
| if(ENABLE_MW_PROFILING) | |
| list(APPEND SOURCES PerfProfiler.cpp) | |
| endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is redundant logic in the CMakeLists.txt file. Lines 171-173 check ENABLE_MW_PROFILING and append PerfProfiler.h to LIBPLAYERGSTINTERFACE_HEADERS, but PerfProfiler.h is already added unconditionally at line 169. The conditional block is unnecessary since the header is already in the list. Remove either the unconditional addition at line 169 or the conditional block at lines 171-173.