Skip to content

Feature/rdkemw 13310 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dp0000 wants to merge 22 commits into
base: feature/dev_sprint_pli
Choose a base branch
from
Open

Feature/rdkemw 13310 #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
313035d
RDKEMW-13310: Telemetry T2 markers for Player-interface component
Deepikasri1234 Feb 17, 2026
beae9af
T2 changes
Deepikasri1234 Feb 18, 2026
71a8b63
resovling compilation issues
Deepikasri1234 Feb 19, 2026
b9d1c24
underflow msg added
Deepikasri1234 Feb 19, 2026
7c20fb0
static code usage is removed
Deepikasri1234 Feb 19, 2026
aaa77d4
Merge branch 'develop' into feature/RDKEMW-13310
Deepikasri1234 Feb 23, 2026
64366e1
resolving conflicts
Deepikasri1234 Feb 23, 2026
f404e6e
added error PTS conditions
Deepikasri1234 Mar 4, 2026
7339125
Merge branch 'feature/dev_sprint_pli' into feature/RDKEMW-13310
Deepikasri1234 Mar 4, 2026
e4d686e
resolved compilation isseus
Deepikasri1234 Mar 4, 2026
9148d7e
resolved compilation issues
Deepikasri1234 Mar 5, 2026
b0ace39
Merge branch 'feature/dev_sprint_pli' into feature/RDKEMW-13310
Deepikasri1234 Mar 6, 2026
1692915
removed additional logic handled
Deepikasri1234 Mar 6, 2026
3a28ef6
added prints
Deepikasri1234 Mar 6, 2026
0ccd026
fixed compilation issues
Deepikasri1234 Mar 6, 2026
6107254
Merge branch 'feature/dev_sprint_pli' into feature/RDKEMW-13310
Deepikasri1234 Mar 9, 2026
b67c5a6
Merge branch 'feature/dev_sprint_pli' into feature/RDKEMW-13310
Deepikasri1234 Mar 11, 2026
3c90d8a
added debug
Deepikasri1234 Mar 12, 2026
fe2013c
Merge branch 'feature/dev_sprint_pli' into feature/RDKEMW-13310
Deepikasri1234 Mar 12, 2026
16117e1
added few telemetry markers
Deepikasri1234 Mar 25, 2026
4f6db42
added new set of markers
Deepikasri1234 Mar 31, 2026
c13064e
Merge branch 'feature/dev_sprint_pli' into feature/RDKEMW-13310
Deepikasri1234 Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,12 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
else()
set(LIBPLAYERGSTINTERFACE_DEPENDS ${OS_LD_FLAGS} ${UUID_LINK_LIBRARIES} ${LIBCJSON_LINK_LIBRARIES} ${GSTREAMERBASE_LINK_LIBRARIES} ${GSTREAMER_LINK_LIBRARIES} ${CURL_LINK_LIBRARIES} ${LIBDASH_LINK_LIBRARIES} ${LibXml2_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT} ${OPENSSL_LIBRARIES} ${OPENGL_LIBRARIES} ${GLEW_LIBRARIES} -ldl)
endif()

if(CMAKE_TELEMETRY_2_0_REQUIRED)
message("CMAKE_TELEMETRY_2_0_REQUIRED set")
set(LIBPLAYERGSTINTERFACE_SOURCES "${LIBPLAYERGSTINTERFACE_SOURCES}" PlayerTelemetry2.cpp)
set(LIBPLAYERGSTINTERFACE_DEFINES "${LIBPLAYERGSTINTERFACE_DEFINES} -DPLAYER_TELEMETRY_SUPPORT=1")
set(LIBPLAYERGSTINTERFACE_DEPENDS ${LIBPLAYERGSTINTERFACE_DEPENDS} "-ltelemetry_msgsender")
Comment on lines +143 to +145
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appending PlayerTelemetry2.cpp to LIBPLAYERGSTINTERFACE_SOURCES via set(LIBPLAYERGSTINTERFACE_SOURCES "${LIBPLAYERGSTINTERFACE_SOURCES}" PlayerTelemetry2.cpp) can accidentally turn a list into a single semicolon-delimited string and behaves differently from other source additions in this CMakeLists. Prefer list(APPEND LIBPLAYERGSTINTERFACE_SOURCES PlayerTelemetry2.cpp) (or unquoted ${LIBPLAYERGSTINTERFACE_SOURCES}) for consistent list handling.

Suggested change
set(LIBPLAYERGSTINTERFACE_SOURCES "${LIBPLAYERGSTINTERFACE_SOURCES}" PlayerTelemetry2.cpp)
set(LIBPLAYERGSTINTERFACE_DEFINES "${LIBPLAYERGSTINTERFACE_DEFINES} -DPLAYER_TELEMETRY_SUPPORT=1")
set(LIBPLAYERGSTINTERFACE_DEPENDS ${LIBPLAYERGSTINTERFACE_DEPENDS} "-ltelemetry_msgsender")
list(APPEND LIBPLAYERGSTINTERFACE_SOURCES PlayerTelemetry2.cpp)
set(LIBPLAYERGSTINTERFACE_DEFINES ${LIBPLAYERGSTINTERFACE_DEFINES} -DPLAYER_TELEMETRY_SUPPORT=1)
set(LIBPLAYERGSTINTERFACE_DEPENDS ${LIBPLAYERGSTINTERFACE_DEPENDS} -ltelemetry_msgsender)

Copilot uses AI. Check for mistakes.
endif()
set(LIBPLAYERGSTINTERFACE_HEADERS
closedcaptions/CCTrackInfo.h
GstUtils.h
Expand Down
8 changes: 8 additions & 0 deletions GstHandlerControl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

#include "GstHandlerControl.h"
#include "PlayerLogManager.h"
#include "TelemetryMarkers.h"
#include "PlayerTelemetry.h"
#include <cstdio>
#include <string>

Expand Down Expand Up @@ -75,6 +77,12 @@ bool GstHandlerControl::waitForDone(int MaximumDelayMilliseconds, std::string na
{
MW_LOG_ERR("GstPlayer: %d instance%s of %s running",
mInstanceCount, mInstanceCount?"s":"", name.c_str());
{
TelemetryPayload handlerPayload;
handlerPayload.add("handler", name);
handlerPayload.add("count", mInstanceCount);
PlayerTelemetry::sendEvent(TELEMETRY_EVENT_HANDLER_TIMEOUT, handlerPayload);
}
return false;
}
else
Expand Down
Loading
Loading