Skip to content

nm-cli unmanage wl0.2#289

Open
aminaseyyad wants to merge 2 commits intodevelopfrom
topic/RDKMVE-1740-Miracast
Open

nm-cli unmanage wl0.2#289
aminaseyyad wants to merge 2 commits intodevelopfrom
topic/RDKMVE-1740-Miracast

Conversation

@aminaseyyad
Copy link
Copy Markdown

For disabling broadcom Miracast P2P interfaces, doing wl0.2 unmanaged in nmcli

@aminaseyyad aminaseyyad requested a review from a team as a code owner March 13, 2026 06:29
Copilot AI review requested due to automatic review settings March 13, 2026 06:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GNOME NetworkManager plugin startup script to prevent Broadcom Miracast P2P interfaces from being managed by NetworkManager (by disconnecting them and setting them unmanaged via nmcli).

Changes:

  • Add a loop to disconnect and mark wl0.2 and p2p-dev-wl0.2 as unmanaged.
  • Add logging for the new P2P unmanage actions.
  • Ensure the script exits successfully at the end.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 17, 2026 08:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds logic to the NetworkManager interface handler script to disable Broadcom Miracast P2P interfaces by marking them unmanaged via nmcli during startup.

Changes:

  • Add a P2P interface list (wl0.2, p2p-dev-wl0.2) and loop to disconnect + set unmanaged.
  • Append P2P-related actions to /opt/logs/NMMonitor.log.
  • Add an explicit exit 0 at the end of the script.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines +85 to +87
echo "`/bin/timestamp` :$0: setting $P2P_IF unmanaged for Miracast" >> /opt/logs/NMMonitor.log
nmcli device disconnect "$P2P_IF" 2>/dev/null
nmcli dev set "$P2P_IF" managed no 2>/dev/null
Comment on lines +81 to +82
# Disable Broadcom Miracast P2P interfaces
P2P_INTERFACES="wl0.2 p2p-dev-wl0.2"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants