Skip to content

RDKEMW-14910: IPv6 ULA field in network interface API response #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmuhammedrafi wants to merge 13 commits into
base: develop
Choose a base branch
from
+39 −18
Open

RDKEMW-14910: IPv6 ULA field in network interface API response #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
117728c
RDKEMW-14910 IPv6 ULA field in network interface API response
cmuhammedrafi Mar 3, 2026
4423fcf
updated print
cmuhammedrafi Mar 16, 2026
c4521e4
Test update
cmuhammedrafi Mar 17, 2026
322337e
log line attiribute
cmuhammedrafi Mar 17, 2026
0e94052
revert all test changes
cmuhammedrafi Mar 17, 2026
075d8ec
updated the workflow
cmuhammedrafi Mar 24, 2026
dc0d477
Merge branch 'develop' into topic/RDKEMW-14910
cmuhammedrafi Mar 24, 2026
317cf45
updated copilot review comment
cmuhammedrafi Mar 24, 2026
21f7661
update co pilot review
cmuhammedrafi Mar 24, 2026
474d4f9
update prifix
cmuhammedrafi Mar 24, 2026
caabbe4
Apply suggestion from @Copilot
karuna2git Mar 24, 2026
6fb33dc
update copilot review comment
cmuhammedrafi Mar 25, 2026
d903883
update review comments
cmuhammedrafi Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions plugin/gnome/NetworkManagerGnomeEvents.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,11 +343,14 @@ namespace WPEFramework
//int prefix = nm_ip_address_get_prefix(address);
if(ipaddr != NULL) {
std::string ipAddress = ipaddr;
if (ipAddress.compare(0, 5, "fe80:") == 0 ||
ipAddress.compare(0, 6, "fe80::") == 0) {
NMLOG_DEBUG("%s It's link-local ip", ipAddress.c_str());
continue; // It's link-local so skiping
if(ipAddress[0] != '2' && ipAddress[0] != '3')
{
// Global Unicast Address (RFC 4291, 2000::/3)
// 2000::/3 covers first bytes 0x20-0x3f, which in hex string always starts with '2' or '3'.
NMLOG_DEBUG("%s Not a global unicast address", ipAddress.c_str());
continue;
Comment on lines 344 to +351
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ipAddress[0] is accessed without checking ipAddress is non-empty. If nm_ip_address_get_address() returns an empty string (or something that becomes empty after conversion), this is undefined behavior and can crash. Add an ipAddress.empty() guard before indexing.

Copilot uses AI. Check for mistakes.
}

GnomeNetworkManagerEvents::onAddressChangeCb(iface, ipAddress, true, true);
break; // SLAAC protocol may include multip ipv6 address posting only one Global address
}
Expand Down
36 changes: 26 additions & 10 deletions plugin/gnome/NetworkManagerGnomeProxy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,7 @@ namespace WPEFramework
NMLOG_WARNING("no IPv4 configurtion on %s", interface.c_str());
if(ipByte)
{
for (int i = 0; i < ipByte->len; i++)
for (guint i = 0; i < ipByte->len; i++)
{
ipAddr = static_cast<NMIPAddress*>(ipByte->pdata[i]);
if(ipAddr)
Expand Down Expand Up @@ -768,28 +768,44 @@ namespace WPEFramework
if(ip6_config)
ipArray = nm_ip_config_get_addresses(ip6_config);
else
NMLOG_WARNING("no IPv6 configurtion on %s", interface.c_str());
NMLOG_WARNING("no IPv6 configuration on %s", interface.c_str());
if(ipArray)
{
for (int i = 0; i < ipArray->len; i++)
for (guint i = 0; i < ipArray->len; i++)
{
ipAddr = static_cast<NMIPAddress*>(ipArray->pdata[i]);
if(ipAddr)
ipStr = nm_ip_address_get_address(ipAddr);
if(ipAddr == nullptr)
{
NMLOG_WARNING("Failed to get IP address from NMIPAddress struct");
continue;
}

ipStr = nm_ip_address_get_address(ipAddr);

if(!ipStr.empty())
{
if (ipStr.compare(0, 5, "fe80:") == 0 || ipStr.compare(0, 6, "fe80::") == 0)
if(ipStr.compare(0, 2, "fc") == 0 || ipStr.compare(0, 2, "fd") == 0)
{
result.ula = ipStr;
NMLOG_INFO("link-local ip: %s", result.ula.c_str());
// ULA - Unique Local Address (RFC 4193, fc00::/7)
// fc00::/7 covers first bytes 0xfc and 0xfd, so the string starts with "fc" or "fd".
if(result.ula.empty())
result.ula = ipStr;
NMLOG_INFO("ula ip: %s", result.ula.c_str());
}
else
else if(ipStr[0] == '2' || ipStr[0] == '3')
{
// Global Unicast Address (RFC 4291, 2000::/3)
// 2000::/3 covers first bytes 0x20-0x3f, which in hex string always starts with '2' or '3'.
result.prefix = nm_ip_address_get_prefix(ipAddr);
if(result.ipaddress.empty()) // SLAAC mutiple ip not added
if(result.ipaddress.empty()) // SLAAC multiple ip not added
result.ipaddress = ipStr;
NMLOG_INFO("global ip %s/%d", ipStr.c_str(), result.prefix);
}
else
{
// Skip everything else: link-local (fe80::/10), loopback (::1), multicast (ff00::/8), etc.
NMLOG_DEBUG("Skipping non-global IPv6 address: %s", ipStr.c_str());
}
}
}

Expand Down
10 changes: 6 additions & 4 deletions tests/l2Test/libnm/l2_test_libnmproxy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,6 +827,7 @@ TEST_F(NetworkManagerTest, GetIPSettings_ipv6_config_valid)
g_ptr_array_add(dummyActiveConn, ethActiveConn);
g_ptr_array_add(ipvAddr, ipv6Addr);
g_ptr_array_add(ipvAddr, reinterpret_cast<NMIPAddress*>(0x100176));
g_ptr_array_add(ipvAddr, reinterpret_cast<NMIPAddress*>(0x100177));

EXPECT_CALL(*p_libnmWrapsImplMock, nm_dhcp_config_get_one_option(::testing::_, ::testing::_))
.WillOnce(::testing::Return("2001:db8::1"));
Expand All @@ -842,11 +843,12 @@ TEST_F(NetworkManagerTest, GetIPSettings_ipv6_config_valid)
.WillOnce(::testing::Return("2001:4860:4860::1"));

EXPECT_CALL(*p_libnmWrapsImplMock, nm_ip_address_get_prefix(::testing::_))
.WillOnce(::testing::Return(64));
.WillOnce(::testing::Return(48));

EXPECT_CALL(*p_libnmWrapsImplMock, nm_ip_address_get_address(::testing::_))
.WillOnce(::testing::Return("fe80::1234:5678:abcd:ef01"))
.WillOnce(::testing::Return("2001:db8:1:2:3:4:5:6"))
.WillOnce(::testing::Return("fe80::1234:5678:abcd:ef01"));
.WillOnce(::testing::Return("fd12:3456:789a::1"));

EXPECT_CALL(*p_libnmWrapsImplMock, nm_ip_config_get_addresses(::testing::_))
.WillOnce(::testing::Return(reinterpret_cast<GPtrArray*>(ipvAddr)));
Expand Down Expand Up @@ -881,8 +883,8 @@ TEST_F(NetworkManagerTest, GetIPSettings_ipv6_config_valid)
EXPECT_TRUE(response.find("\"primarydns\":\"2001:4860:4860::8888\"") != std::string::npos);
EXPECT_TRUE(response.find("\"interface\":\"eth0\"") != std::string::npos);
EXPECT_TRUE(response.find("\"ipaddress\":\"2001:db8:1:2:3:4:5:6\"") != std::string::npos);
EXPECT_TRUE(response.find("\"ula\":\"fe80::1234:5678:abcd:ef01\"") != std::string::npos);
EXPECT_TRUE(response.find("\"prefix\":64") != std::string::npos);
EXPECT_TRUE(response.find("\"ula\":\"fd12:3456:789a::1\"") != std::string::npos);
EXPECT_TRUE(response.find("\"prefix\":48") != std::string::npos);
EXPECT_TRUE(response.find("\"dhcpserver\":\"2001:db8::1\"") != std::string::npos);
EXPECT_TRUE(response.find("\"gateway\":\"2001:4860:4860::1\"") != std::string::npos);

Expand Down
Loading